Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an Address block for [bw_address] #5

Closed
bobbingwide opened this issue Feb 11, 2018 · 3 comments
Closed

Create an Address block for [bw_address] #5

bobbingwide opened this issue Feb 11, 2018 · 3 comments
Assignees
@bobbingwide

Comments

@bobbingwide
Copy link
Owner

Requirement

  • To easily add an Address block to content

Initial solution

A static block that will

  • Display a simple heading
  • Implement the [bw_address] shortcode
  • The heading can be styled using Additional CSS class(es)

Future solution

Develop a long term replacement to accept the fields instead of having to use complicated parameters
@bobbingwide bobbingwide self-assigned this Feb 11, 2018
bobbingwide referenced this issue in bobbingwide/oik-block Feb 11, 2018
@bobbingwide
Issue #2 - Create an address block for [bw_address]
cff9dc1
bobbingwide referenced this issue in bobbingwide/oik-block Feb 11, 2018
@bobbingwide
Issue #1, issue #2, issue #4 - update the main importer
d8c2e21
@bobbingwide bobbingwide transferred this issue from bobbingwide/oik-block Nov 21, 2018
@bobbingwide bobbingwide mentioned this issue Nov 23, 2018
Closed
@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 3, 2019 •
edited
Loading

Having discovered the wonders of Server Side Rendering I now want to try changing the Address block to implement this. Can we display the Address title optionally?

This is the basic block before making it server side rendered.
oik-block-address

bobbingwide added a commit that referenced this issue Jan 15, 2019
@bobbingwide
Issue #5 - Change Address block to server side rendered. Issue #21 - …
047ab9f 
…ensure shortcode fields are expanded
@bobbingwide
Copy link
Owner Author

A new address block may appear as the escaped HTML. Wacky eh?

Problem occurs when

  • the address is not defined
  • the display format ( Block or Inline ) has not been selected
  • the address is server side rendered.

@bobbingwide
Copy link
Owner Author

The Address block is now in oik. See bobbingwide/oik#177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide