Skip to content

Commit

Permalink
Fix TV tests
Browse files Browse the repository at this point in the history
Summary:
Saw in [travis jobs](https://travis-ci.org/Instagram/IGListKit/jobs/177139465) that TV tests were failing. Fixed some file target memberships. Not sure why failing TV tests wouldn't fail Travis tho.

Maybe fix Instagram#227

If we don't get coverage reports I'll amend removing `cd $TAVIS_BUILD_DIR` and see what happens.

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes Instagram#228

Differential Revision: D4210696

Pulled By: rnystrom

fbshipit-source-id: 695c1211353790163e1dd11176b2dc801d83e3f7
  • Loading branch information
Ryan Nystrom authored and Facebook Github Bot committed Nov 20, 2016
1 parent 7a4ebc9 commit f05ae5b
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
- IOS_SCHEME="IGListKit"
- TVOS_SCHEME="IGListKit-tvOS"

- IOS_SDK=iphonesimulator10.0
- IOS_SDK=iphonesimulator10.1
- TVOS_SDK=appletvsimulator10.0

- EXAMPLE_WORKSPACE="IGListKitExamples.xcworkspace"
Expand Down Expand Up @@ -61,4 +61,4 @@ script:
fi

after_success:
- cd $TRAVIS_BUILD_DIR && slather
- slather
18 changes: 16 additions & 2 deletions IGListKit.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
26271C8A1DAE94E40073E116 /* IGTestSingleNibItemDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 26271C891DAE94E40073E116 /* IGTestSingleNibItemDataSource.m */; };
26271C8C1DAE96740073E116 /* IGListSingleNibItemControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 26271C8B1DAE96740073E116 /* IGListSingleNibItemControllerTests.m */; };
290486201DCD02750007F41D /* IGTestNibSupplementaryView.h in Headers */ = {isa = PBXBuildFile; fileRef = 2904861E1DCD02750007F41D /* IGTestNibSupplementaryView.h */; };
290486211DCD02750007F41D /* IGTestNibSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */; };
2914BEE91DCD15F400C96401 /* IGTestNibSupplementaryView.xib in Resources */ = {isa = PBXBuildFile; fileRef = 2904861C1DCD02140007F41D /* IGTestNibSupplementaryView.xib */; };
2914BEEA1DCD15F400C96401 /* IGTestNibSupplementaryView.xib in Resources */ = {isa = PBXBuildFile; fileRef = 2904861C1DCD02140007F41D /* IGTestNibSupplementaryView.xib */; };
294AC6321DDE4C19002FCE5D /* IGListDiffResultTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */; };
Expand All @@ -32,6 +31,14 @@
29C4748E1DDF460500AE68CE /* IGListAdapterStoryboardTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F11DC284C300B3AAE7 /* IGListAdapterStoryboardTests.m */; };
29C4748F1DDF460500AE68CE /* IGListDiffResultTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 294AC6311DDE4C19002FCE5D /* IGListDiffResultTests.m */; };
29C474901DDF460500AE68CE /* IGListSectionMapTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 829D7BA81DD1816400549816 /* IGListSectionMapTests.m */; };
29C5792E1DE0DA89003A149B /* IGTestNibSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */; };
29C5792F1DE0DA8A003A149B /* IGListTestAdapterStoryboardDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7FA1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m */; };
29C579301DE0DA8A003A149B /* IGListTestStoryboardSection.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F71DC2F3FB00B3AAE7 /* IGListTestStoryboardSection.m */; };
29C579311DE0DA8A003A149B /* IGTestNibSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 2904861F1DCD02750007F41D /* IGTestNibSupplementaryView.m */; };
29C579321DE0DA8A003A149B /* IGTestStoryboardSupplementarySource.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7F41DC2D99300B3AAE7 /* IGTestStoryboardSupplementarySource.m */; };
29C579331DE0DA8A003A149B /* IGTestStoryboardSupplementaryView.m in Sources */ = {isa = PBXBuildFile; fileRef = 8240C7EF1DC272CA00B3AAE7 /* IGTestStoryboardSupplementaryView.m */; };
29C579341DE0DB30003A149B /* IGListAdapterProxy.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F481D870F3E007C7F66 /* IGListAdapterProxy.m */; };
29C579351DE0DB30003A149B /* IGListAdapterProxy.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F481D870F3E007C7F66 /* IGListAdapterProxy.m */; };
29EA6C491DB43A8000957A88 /* IGTestNibCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 294369B01DB1B7AE0025F6E7 /* IGTestNibCell.xib */; };
5C81083F8E7AEF4B3EBE8871 /* Pods_IGListKitTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FD40284889DE182FFC7F471E /* Pods_IGListKitTests.framework */; };
821BC4C01DB8C9D500172ED0 /* IGListSingleStoryboardItemControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 821BC4BE1DB8C95300172ED0 /* IGListSingleStoryboardItemControllerTests.m */; };
Expand Down Expand Up @@ -999,11 +1006,16 @@
885FE2361DC51B76009CE2B4 /* IGListStackSectionControllerTests.m in Sources */,
885FE2311DC51B76009CE2B4 /* IGListDisplayHandlerTests.m in Sources */,
29C474901DDF460500AE68CE /* IGListSectionMapTests.m in Sources */,
29C579321DE0DA8A003A149B /* IGTestStoryboardSupplementarySource.m in Sources */,
29C5792F1DE0DA8A003A149B /* IGListTestAdapterStoryboardDataSource.m in Sources */,
885FE23B1DC51B86009CE2B4 /* IGListTestUICollectionViewDataSource.m in Sources */,
885FE23D1DC51B86009CE2B4 /* IGTestDelegateController.m in Sources */,
885FE22B1DC51B76009CE2B4 /* IGListAdapterE2ETests.m in Sources */,
885FE2331DC51B76009CE2B4 /* IGListSingleSectionControllerTests.m in Sources */,
29C579311DE0DA8A003A149B /* IGTestNibSupplementaryView.m in Sources */,
885FE23C1DC51B86009CE2B4 /* IGTestCell.m in Sources */,
29C579331DE0DA8A003A149B /* IGTestStoryboardSupplementaryView.m in Sources */,
29C579351DE0DB30003A149B /* IGListAdapterProxy.m in Sources */,
885FE2401DC51B86009CE2B4 /* IGTestSingleItemDataSource.m in Sources */,
885FE2451DC51B86009CE2B4 /* IGTestStoryboardCell.m in Sources */,
885FE22F1DC51B76009CE2B4 /* IGListDiffSwiftTests.swift in Sources */,
Expand All @@ -1026,6 +1038,7 @@
885FE2461DC51B86009CE2B4 /* IGTestSupplementarySource.m in Sources */,
885FE2431DC51B86009CE2B4 /* IGTestStoryboardViewController.m in Sources */,
885FE23A1DC51B86009CE2B4 /* IGListTestSection.m in Sources */,
29C579301DE0DA8A003A149B /* IGListTestStoryboardSection.m in Sources */,
885FE23E1DC51B86009CE2B4 /* IGTestDelegateDataSource.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand All @@ -1047,7 +1060,6 @@
296176FC1D9D54C100F40F34 /* IGListSingleSectionController.m in Sources */,
296177051D9D54E300F40F34 /* IGListSectionMap.m in Sources */,
88144F771D870F3E007C7F66 /* IGListMoveIndex.m in Sources */,
290486211DCD02750007F41D /* IGTestNibSupplementaryView.m in Sources */,
88144F921D870F3E007C7F66 /* IGListWorkingRangeHandler.mm in Sources */,
88144F5D1D870F3E007C7F66 /* IGListAdapter.m in Sources */,
88144F611D870F3E007C7F66 /* IGListAdapterUpdater.m in Sources */,
Expand All @@ -1073,6 +1085,7 @@
8240C7FB1DC2F6CF00B3AAE7 /* IGListTestAdapterStoryboardDataSource.m in Sources */,
88144F131D870EDC007C7F66 /* IGListTestAdapterDataSource.m in Sources */,
88144F071D870EDC007C7F66 /* IGListAdapterE2ETests.m in Sources */,
29C579341DE0DB30003A149B /* IGListAdapterProxy.m in Sources */,
88144F111D870EDC007C7F66 /* IGListStackSectionControllerTests.m in Sources */,
88144F1A1D870EDC007C7F66 /* IGTestObject.m in Sources */,
88144F0B1D870EDC007C7F66 /* IGListDiffSwiftTests.swift in Sources */,
Expand All @@ -1081,6 +1094,7 @@
88144F0A1D870EDC007C7F66 /* IGListBatchUpdateDataTests.m in Sources */,
26271C8C1DAE96740073E116 /* IGListSingleNibItemControllerTests.m in Sources */,
829D7BAA1DD1819000549816 /* IGListSectionMapTests.m in Sources */,
29C5792E1DE0DA89003A149B /* IGTestNibSupplementaryView.m in Sources */,
88144F101D870EDC007C7F66 /* IGListSingleSectionControllerTests.m in Sources */,
88144F121D870EDC007C7F66 /* IGListWorkingRangeHandlerTests.m in Sources */,
821BC4D31DB981AB00172ED0 /* IGTestSingleStoryboardItemDataSource.m in Sources */,
Expand Down

0 comments on commit f05ae5b

Please sign in to comment.