add command make check_valgrind
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Jun 10, 2019
|
Awesome ! |
varunagrawal
added a commit
that referenced
this pull request
Mar 25, 2021
548e61b1f Merge pull request #57 from borglab/fix/configurable-matlab-include b58eabaf1 set correct template file path 483cdab9c fix 1f393516d fix CI syntax 8f0a3543f more concise cmake command because we don't care about the extra files generated 641ad1326 update CI to run cmake de6b9260f added CMake variable to configure the include directory for matlab.h cbe5f18bc Merge pull request #54 from borglab/feature/refactor2 cc78ee3bb test formatting 046a50b01 break down interface_parser into a submodule of smaller parts git-subtree-dir: wrap git-subtree-split: 548e61b1fbf02759d2e4a52435c2f1b3cbde98f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new target
make check_valgrindand one new targetmake check.xxx.run.valgrindfor each individual test.Current limitation: even the latest version of valgrind does not handle AVX/AVX2 instructions, so gtsam must be built with
GTSAM_BUILD_WITH_MARCH_NATIVE=OFF.