Fix issue when uploading to new buckets not in the standard region #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates an HTTP (not HTTPS) subclass and just copies the class dictionary of the HTTP method overrides into the HTTPS subclass. Added an integration test for this as well.
| def add_expect_header(operation, params, **kwargs): | ||
| if operation.http.get('method', '') not in ['PUT', 'POST']: | ||
| return | ||
| if operation.service.endpoint_prefix != 's3': |
There was a problem hiding this comment.
Since we use before-call.s3 for the event, is checking the endpoint prefix necessary here?
There was a problem hiding this comment.
Yeah it's not necessary, I'll remove.
|
Outside of my comment above, this looks good to me. |
This can never happen because we subscribe to a specific s3 event. This was mentioned in code review feedback.
This was referenced Jun 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the expect 100 continue support in order to address the case where you can't upload large files to newly created bucket in the non standard region. The fix consisted of 3 parts:
cc @danielgtaylor