Fix py2.6 for expect 100 continue #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates an HTTP (not HTTPS) subclass and just copies the class dictionary of the HTTP method overrides into the HTTPS subclass. Added an integration test for this as well.
The issue is that py2.6's _send_request is different than the other supported python versions. Because of this, we have to add a check such that we don't send the body if this response_received flag has been set.
operation param is now added to the event.
|
LGTM 🚢-it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is #303 (which was reverted because it didn't work in py2.6 + the fix for py2.6. The py2.6 is in this commit.
The issue is that py2.6's _send_request is different
than the other supported python versions. Because of this,
we have to add a check such that we don't send the body if
this response_received flag has been set.
Verified this works on py2.6, py2.7, py3.3, py3.4. Integration tests passing on all versions.
cc @danielgtaylor