Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set location of credentials file with AWS_CREDENTIALS_… #600

Closed
wants to merge 1 commit into from

Conversation

freimer
Copy link

@freimer freimer commented Jul 7, 2015

…FILE environment variable

Sorry, I don't know how to add to the unit tests...

Signed-off-by: Fred Reimer [email protected]

…FILE environment variable

Signed-off-by: Fred Reimer <[email protected]>
@mtdowling mtdowling added the feature-request This issue requests a feature. label Jul 7, 2015
@jamesls
Copy link
Member

jamesls commented Jul 14, 2015

I agree we should add an env var for this value.

However, that env var name is already used to support pre-existing CLI tools (https://github.com/boto/botocore/blob/develop/botocore/credentials.py#L347) which is a different file with a different format. We'll need to choose another env name.

The java sdk uses AWS_CREDENTIAL_PROFILES_FILE (https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/auth/profile/ProfilesConfigFile.java#L73), so perhaps we can just use that env var to be consistent.

@jamesls
Copy link
Member

jamesls commented Aug 11, 2015

Sorry for the delay, I do like AWS_CREDENTIALS_FILE but as I mentioned it's already taken. I discussed this with the team and we'll just go with AWS_SHARED_CREDENTIALS_FILE.

@jamesls
Copy link
Member

jamesls commented Aug 11, 2015

Merged in your pull request and renamed the env var to AWS_SHARED_CREDENTIALS_FILE. Tracking here: #623

@jamesls jamesls closed this Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants