Support AWS_SHARED_CREDENTIALS_FILE #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FILE environment variable Signed-off-by: Fred Reimer <[email protected]>
Note that this is just changing a config value. Also added an integration test for this.
This was referenced Aug 11, 2015
jamesls
added
the
pr/needs-review
|
Linking original issue: #599 |
|
Looks good. 🚢 It would also be nice to update any related documentation. I know there is some documentation in the CLI that will need to be updated like in the README and possibly a topic guide. |
|
Yeah I checked the botocore docs and didn't see anything. I'll send a PR updating the CLI docs shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in #600, and renames the env var to
AWS_SHARED_CREDENTIALS_FILE. It also adds an integration test to verify behavior.Note that there's no actual new code. It's just changing a config value from None to
AWS_SHARED_CREDENTIALS_FILE, and that mechanism for the env var->config file->default lookup is already tested. So it seems reasonable to add an integration test to verify that this specific value was being picked up.cc @kyleknap @mtdowling @rayluo