4.0.4 snapshot #86

bpangburn · 2021-03-18T01:19:45Z

SSBaseComboBox.updateOption(). Combo editor was not updating consistently. See SSDBComboBox.updateOption() not always updating combo editor text #85
Updated Log4j and JUnit Maven dependencies.
Added explicit Maven plugins versions to eliminate warnings.
Initial fix for Issue Move updateSSComponent() from combo implementations in SSBaseComboBox #46 moving updateSSComponent out of SSComboBox and SSDBComboBox.

If updateOption of current selection, re-select

errael

Only really looked at base combo.

errael · 2021-03-18T20:06:43Z

swingset/src/main/java/com/nqadmin/swingset/SSBaseComboBox.java

+	@SuppressWarnings("unchecked")
+	@Override
+	public void updateSSComponent() {
+		// TODO Modify this class similar to updateSSComponent() in SSFormattedTextField and only limit JDBC types accepted
+		try {
+			// If initialization is taking place then there won't be any mappings so don't try to update anything yet.
+			if (!hasItems()) {
+				return;
+			}
+
+			// Maybe insures blank in case of later exception.
+			setSelectionPending(true);
+
+			// SSDBComboBox will generally work with primary key column data queried from the database, which will generally be of data type long.
+			// SSComboBox is generally used with 2 or 4 byte integer columns.
+			final String boundColumnText = getBoundColumnText();
+
+			// LOGGING
+			logger.debug("{}: getBoundColumnText() - " + boundColumnText, () -> getColumnForLog());
+
+			// GET THE BOUND VALUE STORED IN THE ROWSET - may throw a NumberFormatException
+			M targetValue = null;
+			if ((boundColumnText != null) && !boundColumnText.isEmpty()) {
+				// https://github.com/bpangburn/swingset/issues/46
+				if (this instanceof SSComboBox) {
+					targetValue = (M)(Object)Integer.parseInt(boundColumnText);
+				} else if (this instanceof SSDBComboBox) {
+					targetValue = (M)(Object)Long.parseLong(boundColumnText);
+				} else {
+					throw new Exception();
+				}
+			}
+
+			// LOGGING
+			logger.debug("{}: targetValue - " + targetValue, () -> getColumnForLog());


Patch on the way to minimize unchecked scope and avoid creating StringBuilder when not logging

Minimize unchecked scope. Avoid StringBuilder in logging

… into 4.0.4-SNAPSHOT

errael

A couple of comments on the comments. Which may, or may not, be entirely correct, but probably something to consider.

errael · 2021-03-19T14:52:12Z

swingset/src/main/java/com/nqadmin/swingset/SSDBComboBox.java

@@ -1484,16 +1481,29 @@ public void setSeperator(final String _separator) {
 	 */


(can't add this comment above where I want to)

NOTE: To retain changes made to current RowSet, call updateRow() before
* calling the updateOption() on SSDBComboBox. This only applies if you if you
* are using the SSDBComboBox and SSDataNavigator for record navigation. If you
* are not using the SSDBComboBox for record navigation then there is no need to
* call updateRow() on the RowSet.

A why would be useful for me about this. Maybe the first sentence, could be something like

This method may change the current row without the navigator doing autoupdate.

I'm not sure the suggestion is accurate. And the comment says "current RowSet", would currentRow be more specific? Or maybe this warning is no longer needed given this PRs latest change.

Agree that this comment seems unnecessary. Best practice would be to use SSSyncManager. If a developer is coding up a custom combo navigator then they can make whatever decisions/assumptions they want about when to save changes to a row. I'll push an update removing the comment.

Also added the SSSyncManager tweak to the CHANGELOG.

errael · 2021-03-19T15:06:04Z

swingset/src/main/java/com/nqadmin/swingset/SSDBComboBox.java

+				// TODO: Possible that this block and isSelectedItem variable
+				// may be eliminated if a bug is discovered/fixed in GlazedLists.


Changing what's in the ComboEditor, which may be done indirectly when modifying the current item, might change the currently selected item when STRICT. So something is needed to insure that the selected mapping before the change is the selected mapping after the change. Otherwise the first item in the list becomes selected (as has been seen, and I guess that's what kicks the navigator?)

Notice that the bug glazedlists/glazedlists#702 affects subsequent programmatic changes to the underlying EventList, not the first one.

@errael are you saying that we would want to retain the if (isSelectedItem) { check regardless of whether glazedlists/glazedlists#702 turns out to be a bug and is fixed? In that case we should just eliminate the TODO and possibly replace with a comment similar to what you wrote above?

are you saying that we would want to retain the if (isSelectedItem) { check

Yes, that's what I meant. My assumption is that the mapping that was selected before updateOption is called should be the mapping after the call. Typically, if the selected item is changed, glazed will change the selection.

eliminate the TODO

That works. The comment that's there may need adjustment/clarification.

If, updateOption doesn't need to maintain the selected mapping, then the if could be removed after the glazed bug is fixed. I don't recall exactly, but I think the setSelectedItem(item) is what avoid the glazed bug on the next change.

to date object

…t.git into 4.0.4-SNAPSHOT

bpangburn · 2021-03-24T15:31:09Z

swingset/src/main/java/com/nqadmin/swingset/SSDBComboBox.java

@@ -1469,12 +1466,6 @@ public void setSeperator(final String _separator) {
 	 * <p>
 	 * If more than one item is present in the combo for that mapping, only the
 	 * first one is changed.
-	 * <p>


@errael See JavaDoc removed per code review.

bpangburn · 2021-03-24T15:31:43Z

swingset/src/main/java/com/nqadmin/swingset/SSDBComboBox.java

 		boolean result = false;

 		try (Model.Remodel remodel = optionModel.getRemodel()) {
 			final int index = remodel.getMappings().indexOf(_mapping);
 			if (index >= 0) {
+				boolean isSelectedItem = Objects.equals(_mapping, getSelectedMapping());
 				remodel.setOption(index, _option);
 				result = true;


@errael See updated comments and removal of TODO per code review.

bpangburn and others added 11 commits February 22, 2021 18:22

Update version in POMs.

2f13b82

Use DEBUG level by default for demo.

a8734e0

dataNavigator.updatePresentRow() only if navigating.

938f536

Update combo navigator if Part Name changes.

3e78ac1

If updateOption of current selection, re-select

041433c

Merge pull request #84 from bpangburn/UpdateOption_Reselect

7f863a8

If updateOption of current selection, re-select

Updates related to SSDBComboBox.updateOption() Issue (#85).

08f912e

Updated plugin versions.

7ac7db1

Added explicit Maven plugins versions to eliminate warnings.

666f8be

Initial fix for Issue #46 moving updateSSComponent out of SSCombos.

47d6db6

Added initial fix for Issue #46 to changelog.

60817a0

bpangburn requested a review from errael March 18, 2021 01:19

Minimize unchecked scope. Avoid StringBuilder in logging

a50bcf3

errael reviewed Mar 18, 2021

View reviewed changes

bpangburn and others added 3 commits March 18, 2021 19:13

Merge pull request #87 from bpangburn/UncheckedAndLogging

734b2e1

Minimize unchecked scope. Avoid StringBuilder in logging

Fix/restore java-9-plus POM comment.

f0d6610

Merge branch '4.0.4-SNAPSHOT' of https://github.com/bpangburn/swingset/…

c3c3943

… into 4.0.4-SNAPSHOT

errael self-requested a review March 19, 2021 14:38

errael reviewed Mar 19, 2021

View reviewed changes

ppasala and others added 5 commits March 19, 2021 13:10

Updated getObjectToSet method to use Date.valueOf for converting string

047df93

to date object

Merge branch '4.0.4-SNAPSHOT' of https://github.com/bpangburn/swingse…

a999f03

…t.git into 4.0.4-SNAPSHOT

SSTableKeyAdapter - #89

5606dc5

Minor formatting changes.

1fa7916

Updated CHANGELOG and some JavaDoc in SSDBComboBox.updateOption()

6413a99

bpangburn commented Mar 24, 2021

View reviewed changes

bpangburn merged commit 5c70965 into master Mar 24, 2021

bpangburn deleted the 4.0.4-SNAPSHOT branch June 28, 2021 22:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.0.4 snapshot #86

4.0.4 snapshot #86

bpangburn commented Mar 18, 2021

errael left a comment

errael Mar 18, 2021

errael left a comment

errael Mar 19, 2021

bpangburn Mar 23, 2021

bpangburn Mar 23, 2021

errael Mar 19, 2021

bpangburn Mar 23, 2021

errael Mar 24, 2021

bpangburn Mar 24, 2021

bpangburn Mar 24, 2021

errael Mar 24, 2021

		@@ -1484,16 +1481,29 @@ public void setSeperator(final String _separator) {
		*/

		// TODO: Possible that this block and isSelectedItem variable
		// may be eliminated if a bug is discovered/fixed in GlazedLists.

4.0.4 snapshot #86

4.0.4 snapshot #86

Conversation

bpangburn commented Mar 18, 2021

errael left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

errael left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment