Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly layout on connection end re-connection #718

Closed
2 tasks
nikku opened this issue Oct 4, 2017 · 2 comments · Fixed by #988
Closed
2 tasks

Properly layout on connection end re-connection #718

nikku opened this issue Oct 4, 2017 · 2 comments · Fixed by #988
Assignees
@barmac
Labels
enhancement New feature or request modeling
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Oct 4, 2017 •
edited
Loading

This should avoid situations like this after the source or target of a shape got re-connected:

image

Tasks

  • Layout connection while reconnecting
  • Layout connection while connecting
@nikku nikku added enhancement New feature or request modeling labels Oct 4, 2017
@nikku nikku added this to the B23 milestone Oct 4, 2017
@nikku nikku mentioned this issue Oct 4, 2017
Closed
@nikku nikku self-assigned this Oct 5, 2017
@nikku nikku added the in progress Currently worked on label Oct 5, 2017
@nikku nikku added ready Ready to be worked on and removed in progress Currently worked on ready Ready to be worked on labels Oct 22, 2017
@nikku nikku modified the milestones: B23, B24 Oct 27, 2017
@nikku nikku mentioned this issue Dec 22, 2017
Closed
3 tasks
@nikku nikku modified the milestones: B24, B25 Feb 5, 2018
@nikku nikku added the backlog Queued in backlog label Mar 19, 2018
@nikku nikku modified the milestones: B25, B26 May 29, 2018
@nikku nikku removed this from the B26 milestone Jul 13, 2018
@nikku nikku mentioned this issue Nov 29, 2018
Closed
3 tasks
This was referenced Feb 12, 2019
Closed
Closed
@nikku nikku added this to the M29 milestone Mar 6, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
@nikku nikku removed their assignment Apr 2, 2019
@barmac
Copy link
Member

barmac commented Apr 10, 2019

Bare layout seems to be not enough, as #971 does not fix this. I'll tackle this issue separately.

@barmac barmac changed the title Trigger auto-layout on connection end re-connection Properly layout on connection end re-connection Apr 12, 2019
@barmac barmac added in progress Currently worked on and removed ready Ready to be worked on labels Apr 12, 2019
@barmac barmac self-assigned this Apr 12, 2019
barmac added a commit that referenced this issue Apr 18, 2019
@barmac
chore(modeling/label): adjust label position to laid out connection
11fc7b9 
Closes #718
@barmac barmac mentioned this issue Apr 18, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Apr 18, 2019
@barmac barmac mentioned this issue Apr 18, 2019
Merged
nikku pushed a commit that referenced this issue Apr 18, 2019
@barmac @nikku
chore(modeling/label): adjust label position to laid out connection
02c03a7 
Closes #718
merge-me bot pushed a commit that referenced this issue Apr 18, 2019
@barmac @merge-me
chore(modeling/label): adjust label position to laid out connection
55ca4c8 
Closes #718
@nikku
Copy link
Member Author

nikku commented Apr 18, 2019

Closed via #988.

@nikku nikku closed this as completed Apr 18, 2019
@ghost ghost removed the needs review Review pending label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
enhancement New feature or request modeling
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

718 properly layout on reconnect bpmn-io/bpmn-js
2 participants
@nikku @barmac