Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate sequence flows w/ corner when reconnecting elements #672

Closed
franzheidl opened this issue Sep 20, 2017 · 7 comments · Fixed by #1359
Closed

Recalculate sequence flows w/ corner when reconnecting elements #672

franzheidl opened this issue Sep 20, 2017 · 7 comments · Fixed by #1359
Assignees
Labels
BPMN enhancement New feature or request modeling
Milestone

Comments

@franzheidl
Copy link

franzheidl commented Sep 20, 2017

When I have a diagram with sequence flows
And my sequence flows have one or more corner
when I disconnect one of them
and I connect them to another element
then it should look exactly the same way as if I had connected it this way in the first place

screen shot 2017-09-20 at 10 45 30

Observed behavior

Only the part of the sequence flow after the last (yellow) point before the arrow end changes:

screen shot 2017-09-20 at 10 45 41

Desired behavior

The whole sequence flow element should be re-calculated in the same way as if it was placed to connect these two elements in the first place:

screen shot 2017-09-20 at 10 47 51


Depends on bpmn-io/bpmn-js#718

@franzheidl franzheidl changed the title Recalculate sequence flows w/ corner when reconnecting them Recalculate sequence flows w/ corner when reconnecting elements Sep 20, 2017
@nikku
Copy link
Member

nikku commented Sep 21, 2017

I agree that the diagram should be somewhat better layouted after the reconnection. Could you provide us with the diagram so we can reproduce your issue?

@philippfromme
Copy link
Contributor

+1 This would really improve things!

@nikku nikku added this to the Backlog milestone Sep 21, 2017
@franzheidl
Copy link
Author

@nikku Sure, here’s the diagram: https://cl.ly/mhwU

@nikku
Copy link
Member

nikku commented Sep 26, 2017

Seems like we're missing the auto-layout hook on element re-connection. I'll have a look into this one. 👍

@nevries
Copy link
Member

nevries commented Sep 28, 2017

In trainings this would significantly improve the "first impression" for users.

@nikku nikku modified the milestones: Backlog, Camunda BPM 7.8 Oct 4, 2017
@nikku nikku self-assigned this Oct 4, 2017
@nikku nikku added the ready Ready to be worked on label Oct 4, 2017
@nikku nikku modified the milestones: Camunda BPM 7.8, M15 Oct 4, 2017
@nikku
Copy link
Member

nikku commented Oct 4, 2017

Gets addressed via bpmn-io/bpmn-js#718

@nikku nikku removed the ready Ready to be worked on label Oct 24, 2017
@nikku nikku modified the milestones: M15, M16 Oct 27, 2017
@nikku nikku modified the milestones: M16, M20 Jan 25, 2018
@nikku nikku removed their assignment Feb 15, 2018
@philippfromme philippfromme reopened this Mar 19, 2018
@nikku nikku added enhancement New feature or request backlog Queued in backlog labels Mar 19, 2018
@romansmirnov romansmirnov removed this from the M20 milestone Apr 3, 2018
@nikku nikku added this to the M29 milestone Mar 6, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
nikku added a commit that referenced this issue Apr 26, 2019
@ghost ghost assigned nikku Apr 26, 2019
@ghost ghost added needs review Review pending and removed ready Ready to be worked on labels Apr 26, 2019
nikku added a commit that referenced this issue Apr 26, 2019
merge-me bot pushed a commit that referenced this issue May 8, 2019
@pinussilvestrus
Copy link
Contributor

Closed via aafbda4

@ghost ghost removed the needs review Review pending label May 9, 2019
philippfromme pushed a commit that referenced this issue Jun 6, 2019
philippfromme pushed a commit that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN enhancement New feature or request modeling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants