Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should only be possible to move groups on its borders #960

Closed
pinussilvestrus opened this issue Mar 27, 2019 · 1 comment · Fixed by #1011
Closed

It should only be possible to move groups on its borders #960

pinussilvestrus opened this issue Mar 27, 2019 · 1 comment · Fixed by #1011
Assignees
@pinussilvestrus
Labels
modeling ux
Milestone
M29

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Mar 27, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently, it will always start dragging the group (like all other kinds of elements). Therefore it is very hard to navigate inside a group element. That's a general problem regarding navigation in containers (#957).

Mar-27-2019 11-01-54

Describe the solution you'd like

It should only be possible to navigate inside a group, e.g. by enclosing the movable area of a group to its borders. The rest of the shape shouldn't interact in any other way.

Describe alternatives you've considered

.

Additional context

Child of #343
@gimbel gimbel mentioned this issue Mar 27, 2019
Closed
10 tasks
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Mar 27, 2019
@pinussilvestrus
Copy link
Contributor Author

As a first step, it should be possible to move elements into and inside a group (#959)

@pinussilvestrus pinussilvestrus mentioned this issue Apr 3, 2019
Closed
@pinussilvestrus pinussilvestrus added this to the M29 milestone Apr 3, 2019
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed backlog Queued in backlog labels Apr 3, 2019
@pinussilvestrus pinussilvestrus self-assigned this Apr 3, 2019
pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Apr 24, 2019
feat(interaction-events): define hit box for frame elements
cdd90ed 
Make frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Apr 24, 2019
feat(interaction-events): define hit box for frame elements
ffbb5b3 
Make frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
@pinussilvestrus pinussilvestrus mentioned this issue Apr 24, 2019
Merged
4 tasks
pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Apr 30, 2019
feat(interaction-events): define hit box for frame elements
7f7a0f6 
Make frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
pinussilvestrus pushed a commit to bpmn-io/diagram-js that referenced this issue Apr 30, 2019
feat(GraphicsFactory): add djs-frame class
ef732ee 
Makes frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
pinussilvestrus pushed a commit that referenced this issue May 2, 2019
feat(ElementFactory): add #isFrame property on group creation
bdf1b89 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
@pinussilvestrus pinussilvestrus mentioned this issue May 2, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels May 2, 2019
pinussilvestrus pushed a commit that referenced this issue May 2, 2019
feat(ElementFactory): add #isFrame property on group creation
5ceab2c 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue May 2, 2019
@philippfromme
feat(GraphicsFactory): add djs-frame class
f903273 
Makes frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue May 2, 2019
@philippfromme
feat(GraphicsFactory): add djs-frame class
282dedb 
Makes frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
pinussilvestrus pushed a commit that referenced this issue May 7, 2019
feat(ElementFactory): add #isFrame property on group creation
9a0928e 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
pinussilvestrus pushed a commit that referenced this issue May 7, 2019
feat(ElementFactory): add #isFrame property on group creation
cb85ef0 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
philippfromme pushed a commit that referenced this issue May 7, 2019
@philippfromme
feat(ElementFactory): add #isFrame property on group creation
bf5fe2b 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
pinussilvestrus pushed a commit that referenced this issue May 7, 2019
feat(ElementFactory): add #isFrame property on group creation
89886d7 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
@ghost ghost removed the needs review Review pending label May 7, 2019
barmac pushed a commit to bpmn-io/diagram-js that referenced this issue May 7, 2019
@barmac
feat(GraphicsFactory): add djs-frame class
1777477 
Makes frame elements only interactable on the stroke
Relates to bpmn-io/bpmn-js#959
Relates to bpmn-io/bpmn-js#960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
modeling ux
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

Group-Frame support bpmn-io/bpmn-js
1 participant
@pinussilvestrus