Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group-Frame support #1011

Merged
merged 4 commits into from
May 7, 2019
Merged

Group-Frame support #1011

merged 4 commits into from
May 7, 2019

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented May 2, 2019 •
edited
Loading

This pull request aims to handle bpmn:Group elements as frame elements (cf. new diagram frame feature) + add basic support for modeling operations (e.g. resizing)

Done by this PR:

@ghost ghost assigned pinussilvestrus May 2, 2019
@ghost ghost added the needs review Review pending label May 2, 2019
@pinussilvestrus pinussilvestrus force-pushed the group-frame-support branch 3 times, most recently from 50d8282 to a39d171 Compare May 7, 2019 06:50
@pinussilvestrus pinussilvestrus changed the title WIP Group-Frame support Group-Frame support May 7, 2019
Niklas Kiefer and others added 4 commits May 7, 2019 14:01
@philippfromme
feat(ElementFactory): add #isFrame property on group creation
bf5fe2b 
This allows basic support for diagram-js frame elements.

Closes #959
Closes #960
@philippfromme
feat(rules): add resizing of groups
cecfaa2 
Closes #956
@philippfromme
feat(ordering): always render groups on top
7356933 
Closes #979
@philippfromme
test(ResizeShape): add test coverage
e6cc2b8 
* Restructure tests to make them more clear
* Add tests for businessObject updates (especially groups)
@philippfromme philippfromme force-pushed the group-frame-support branch from d5a6186 to e6cc2b8 Compare May 7, 2019 12:10
@ghost ghost assigned philippfromme May 7, 2019
philippfromme
philippfromme approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🥇

@pinussilvestrus pinussilvestrus merged commit 883d6c8 into master May 7, 2019
@ghost ghost removed the needs review Review pending label May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the group-frame-support branch May 7, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees

@philippfromme philippfromme

@pinussilvestrus pinussilvestrus

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pinussilvestrus @philippfromme