Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modeling): adjust default collapsed participant height to 60px #1004

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Apr 29, 2019

This is a follow up to #975.

It sets the default height of collapsed pools to 60px to better align with the behavior of other tools.

This better aligns our collapse behavior with other tools.
@nikku nikku requested a review from gustavjf April 29, 2019 09:18
@ghost ghost assigned nikku Apr 29, 2019
@ghost ghost added the needs review Review pending label Apr 29, 2019
@nikku
Copy link
Member Author

nikku commented Apr 29, 2019

When talking about other tools I looked into Signavio, specifically.

Copy link
Contributor

@gustavjf gustavjf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, what do you think about re-writing the last two assertions in the 'collapsed with expanded pool' test like you've done with the 'expanded with collapsed pool' test?

Other than that, looks good to me.

@nikku
Copy link
Member Author

nikku commented Apr 29, 2019

Done, cf. abe3fc6.

Copy link
Contributor

@gustavjf gustavjf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merge-me merge-me bot merged commit d73ffd5 into master Apr 29, 2019
@ghost ghost removed the needs review Review pending label Apr 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the collapsed-pool-60-px-height branch April 29, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants