Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust height of pool when toggling collapse/expand button #975

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Adjust height of pool when toggling collapse/expand button #975

merged 1 commit into from
Apr 23, 2019

Conversation

gustavjf
Copy link
Contributor

_Which issue does this PR address?

Closes camunda/camunda-modeler#1210

@gustavjf gustavjf added the needs review Review pending label Apr 12, 2019
@gustavjf gustavjf requested a review from barmac April 12, 2019 13:01
@ghost ghost assigned gustavjf Apr 12, 2019
@barmac
Copy link
Member

barmac commented Apr 12, 2019

Change of the width makes us run into new issue:

connection

It seems like we don't layout the connections after replacement.

@nikku
Copy link
Member

nikku commented Apr 12, 2019

Can we simply keep the width as is?

@gustavjf gustavjf force-pushed the adjust-height-of-pool-when-toggling-collapse/expand-button branch from 0687e12 to a7c7d43 Compare April 23, 2019 13:00
@gustavjf
Copy link
Contributor Author

gustavjf commented Apr 23, 2019 •
edited
Loading

Thanks for the feedback @barmac / @nikku. I think the current state looks good from my point of view - auto-resizing of height on collapse toggle and keeping the width as-is so the user doesn't have to manually resize after toggling.

Here's the result, for convenience.

bpmn-js#975

@barmac waiting for your review 👍

@gustavjf gustavjf force-pushed the adjust-height-of-pool-when-toggling-collapse/expand-button branch from a7c7d43 to 0c18043 Compare April 23, 2019 13:53
barmac
barmac approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎

@barmac barmac merged commit 0f7b8f4 into master Apr 23, 2019
@ghost ghost removed the needs review Review pending label Apr 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the adjust-height-of-pool-when-toggling-collapse/expand-button branch April 23, 2019 13:56
@nikku nikku mentioned this pull request Apr 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@gustavjf gustavjf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust height of pool when toggle collapse/expand button
3 participants
@gustavjf @barmac @nikku