Do Not Open Replace Menu If Context Menu Not Open #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philippfromme ready for review for a while 👯♂ |
philippfromme
force-pushed
the
1613-multi-create-replace-menu
branch
from
b468d0b to
2438e2e
Compare
philippfromme
changed the title
philippfromme
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
I simplified the implementation. Instead of checking for the number of elements created we simply do not want to open the replace menu if the context pad is not open. The context pad itself already checks whether to open depending on the number of elements created.
|
🆒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#1613