Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Replace Menu after create shortcut is broken #1613

Closed
nikku opened this issue Nov 27, 2019 · 7 comments · Fixed by #1636
Closed

Open Replace Menu after create shortcut is broken #1613

nikku opened this issue Nov 27, 2019 · 7 comments · Fixed by #1636
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nikku
Copy link
Member

nikku commented Nov 27, 2019

Describe the Bug

Pressing the CTRL / CMD shortcut allows power users to open the new elements replace menu right after element creation. This seems to be broken since the introduction of multi-element create:

capture TxkccF_optimized

Steps to Reproduce

  1. Open test diagram
  2. Create element from the palette by pressing the CTRL/CMD modifier or copy and paste elements pressing CTRL/CMD modifier
  3. See that the replace menu opens in an odd location

Expected Behavior

  • Replace menu does not open when multi-element creating (what should be the target element?)
  • Replace menu opens in the correct location after creation when creating a single element

Environment

  • OS: Any
  • Camunda Modeler Version: v3.4.1, v3.5.0
@nikku nikku added the bug Something isn't working label Nov 27, 2019
@nikku nikku added the ready Ready to be worked on label Dec 9, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus added this to the M33 milestone Dec 10, 2019
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed ready Ready to be worked on labels Dec 10, 2019 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus self-assigned this Dec 10, 2019
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Dec 10, 2019

Was able to reproduce it while pasting but not via palette creation. However, I'll have a look.

Kapture 2019-12-10 at 11 46 13

@pinussilvestrus
Copy link
Contributor

@oguzeroglu @barmac @philippfromme is anybody able to reproduce the first case?

Create element from the palette by pressing the CTRL/CMD

@barmac
Copy link
Collaborator

barmac commented Dec 10, 2019

I cannot reproduce it for creation from palette. For Sub Process it activates the Start Event.

@oguzeroglu
Copy link
Contributor

I can reproduce it with palette creation on a clean master branch:

Kapture 2019-12-10 at 14 40 07

@pinussilvestrus
Copy link
Contributor

What's broken there? The position of the replace menu?

@oguzeroglu
Copy link
Contributor

Yes, this is the original position (does not overlap with the intermediate event):

Screenshot 2019-12-10 at 14 41 59

Not sure if this is the mentioned bug though.

@pinussilvestrus
Copy link
Contributor

The issue that it's overlapping the element is also available in previous versions (e.g. v3.3).

Kapture 2019-12-10 at 14 46 23

I think it's a general problem with the layouting. This issue was more about the fact the replace menu is rendered in an unusable manner in the upper left corner.

@pinussilvestrus pinussilvestrus added needs review Review pending and removed in progress Currently worked on labels Dec 11, 2019 — with bpmn-io-tasks
fake-join bot pushed a commit to bpmn-io/bpmn-js that referenced this issue Dec 16, 2019
@nikku nikku added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Dec 16, 2019 — with bpmn-io-tasks
nikku added a commit that referenced this issue Dec 16, 2019
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Dec 16, 2019
@nikku nikku closed this as completed Dec 16, 2019
@nikku nikku removed the needs review Review pending label Dec 16, 2019 — with bpmn-io-tasks
Ichigo85 pushed a commit to sharedchains/camunda-modeler that referenced this issue Jan 10, 2020
@nikku nikku mentioned this issue Jan 22, 2020
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants