Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup menu trigger action doesn't work for header entries #695

Closed
Tracked by #686
, #1793
...
smbea opened this issue Nov 15, 2022 · 0 comments · Fixed by #696
Closed
Tracked by #686
, #1793
...

Popup menu trigger action doesn't work for header entries #695

smbea opened this issue Nov 15, 2022 · 0 comments · Fixed by #696
Assignees
@smbea
Labels
bug Something isn't working

Comments

@smbea
Copy link
Contributor

smbea commented Nov 15, 2022 •
edited
Loading

Describe the Bug

Popup menu trigger action doesn't work for header entries. This was introduced with the new popup menu (#686) because popupMenu._current.entries now only represents body entries.

Steps to Reproduce

Steps to reproduce the behavior:

  1. try to trigger action of a header entry (eg popupMenu.trigger(globalEvent(headerEntry, { x: 0, y: 0 })); or see bpmn-js test case)

Expected Behavior

popupMenu.trigger should continue to work as before: allowing triggering of all entries.

Environment

Please complete the following information:

  • Library version: 11.0.0-aplha.0
@smbea smbea added the bug Something isn't working label Nov 15, 2022
@smbea smbea self-assigned this Nov 15, 2022
@smbea smbea added the ready Ready to be worked on label Nov 15, 2022
@smbea smbea mentioned this issue Nov 15, 2022
Closed
19 tasks
smbea added a commit that referenced this issue Nov 16, 2022
@smbea
fix(popup): _getEntry to search in headerEntries
ef35917 
Closes #695
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 16, 2022
@smbea smbea mentioned this issue Nov 16, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 16, 2022
smbea added a commit that referenced this issue Nov 17, 2022
@smbea
fix(popup): _getEntry to search in headerEntries
7921462 
Closes #695
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 17, 2022
This was referenced Nov 17, 2022
Merged
Closed
@smbea smbea mentioned this issue Dec 13, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(popup): _getEntry to search in headerEntries bpmn-io/diagram-js
1 participant
@smbea