Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): _getEntry to search in headerEntries #696

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Nov 16, 2022

Closes #695

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 16, 2022
@smbea smbea requested review from a team, philippfromme, barmac and nikku and removed request for a team November 16, 2022 10:05
@nikku
Copy link
Member

nikku commented Nov 16, 2022

Some observations here: The old popup menu actually used PopupMenu#trigger to trigger the event behavior. The new one does not do that anymore, effectively working around the public API.

Shall we adjust the new menu to use PopupMenu#trigger?

Other than that this PR looks good.

@smbea
Copy link
Contributor Author

smbea commented Nov 16, 2022

@nikku I'm not sure what you mean. The new popup menu still provides the PopupMenu#trigger API, see https://github.com/bpmn-io/diagram-js/blob/develop/lib/features/popup-menu/PopupMenu.js#L480. Or did I misunderstand what you meant?

@nikku
Copy link
Member

nikku commented Nov 16, 2022

GitHub messed up the deep link, let me inline it:

image

The old popup menu actually used PopupMenu#trigger internally, on entry click. The new one does not do that. Yes, the API still exists, but it is not used, under the hood.

My suggestion is now to consider restoring that behavior (if it makes sense).

@nikku nikku mentioned this pull request Nov 16, 2022
@smbea smbea merged commit 7921462 into develop Nov 17, 2022
@smbea smbea deleted the 695-fix-popup-trigger branch November 17, 2022 08:24
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup menu trigger action doesn't work for header entries
2 participants