Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keyboard more friendly #707

Closed
Tracked by #1793
smbea opened this issue Nov 22, 2022 · 0 comments · Fixed by #708
Closed
Tracked by #1793

Make keyboard more friendly #707

smbea opened this issue Nov 22, 2022 · 0 comments · Fixed by #708
Assignees

Comments

@smbea
Copy link
Contributor

smbea commented Nov 22, 2022

What should we do?

Make keyboard more friendly in event handling. It shouldn't force handle events.

Current behaviour:

  • It intercepts during capture phase
    • Handles events even if component handles them
  • Does not consider if element has tabIndex
  • Input is not considered only in some cases:
    return isInput(event.target) && this._isModifiedKeyIgnored(event);

It should allow external component to handle their events nicely: if component prevents default, keyboard shouldn't handle it

Why should we do it?

Allow easier handling of events by components.

@smbea smbea added the ready Ready to be worked on label Nov 22, 2022
nikku added a commit that referenced this issue Nov 22, 2022
Ensure we play nice with other UI components up in the component
tree; rather than handling keys on capture, handle events on bubble.

Ignore events that got their propagation stopped or their default
prevented.

Closes #707
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 22, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 22, 2022
nikku added a commit that referenced this issue Nov 22, 2022
Ensure we play nice with other UI components up in the component
tree; rather than handling keys on capture, handle events on bubble.

Ignore events that got their propagation stopped or their default
prevented.

Closes #707
nikku added a commit that referenced this issue Nov 22, 2022
Ensure we play nice with other UI components up in the component
tree; rather than handling keys on capture, handle events on bubble.

Ignore events that got their propagation stopped or their default
prevented.

Closes #707
nikku added a commit that referenced this issue Nov 22, 2022
Ensure we play nice with other UI components up in the component
tree; rather than handling keys on capture, handle events on bubble.

Ignore events that got their propagation stopped or their default
prevented.

Closes #707
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants