-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make keyboard more friendly #707
Comments
nikku
added a commit
that referenced
this issue
Nov 22, 2022
Ensure we play nice with other UI components up in the component tree; rather than handling keys on capture, handle events on bubble. Ignore events that got their propagation stopped or their default prevented. Closes #707
bpmn-io-tasks
bot
added
in progress
Currently worked on
and removed
ready
Ready to be worked on
labels
Nov 22, 2022
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Nov 22, 2022
nikku
added a commit
that referenced
this issue
Nov 22, 2022
Ensure we play nice with other UI components up in the component tree; rather than handling keys on capture, handle events on bubble. Ignore events that got their propagation stopped or their default prevented. Closes #707
nikku
added a commit
that referenced
this issue
Nov 22, 2022
Ensure we play nice with other UI components up in the component tree; rather than handling keys on capture, handle events on bubble. Ignore events that got their propagation stopped or their default prevented. Closes #707
nikku
added a commit
that referenced
this issue
Nov 22, 2022
Ensure we play nice with other UI components up in the component tree; rather than handling keys on capture, handle events on bubble. Ignore events that got their propagation stopped or their default prevented. Closes #707
19 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What should we do?
Make keyboard more friendly in event handling. It shouldn't force handle events.
Current behaviour:
tabIndex
diagram-js/lib/features/keyboard/Keyboard.js
Line 112 in 5f42235
It should allow external component to handle their events nicely: if component prevents default, keyboard shouldn't handle it
Why should we do it?
Allow easier handling of events by components.
The text was updated successfully, but these errors were encountered: