Make keyboard friendly enough #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
|
I did integration test this against bpmn-js and found #709 (unrelated to this change). |
Ensure we play nice with other UI components up in the component tree; rather than handling keys on capture, handle events on bubble. Ignore events that got their propagation stopped or their default prevented. Closes #707
nikku
force-pushed
the
707-friendly-enough-keyboard
branch
from
f0aef63 to
57e939d
Compare
smbea
approved these changes
Nov 22, 2022
|
Great improvement 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we play nice with other UI components up in the component tree; rather than handling keys on capture, handle events on bubble. Ignore events that got their propagation stopped or their default prevented.
A result of this PR is that components downwards in the component tree can use standard DOM facilities to prevent the event from being handled by keyboard:
Closes #707