Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hide overlays on canvas move #798

Closed
marstamm opened this issue Aug 23, 2023 · 1 comment · Fixed by #799
Closed

Don't hide overlays on canvas move #798

marstamm opened this issue Aug 23, 2023 · 1 comment · Fixed by #799
Assignees
@marstamm
Labels
spring cleaning Could be cleaned up one day

Comments

@marstamm
Copy link
Contributor

What should we do?

Overlays should not hide on canvas move

Why should we do it?

Is is confusing to the user why diagram elements flicker when moving the canvas. Browsers got more powerful over the last 8 years, so performance of CSS transforms should no longer be a big impact.
@marstamm marstamm added ready Ready to be worked on spring cleaning Could be cleaned up one day labels Aug 23, 2023
@marstamm marstamm self-assigned this Aug 23, 2023
@marstamm marstamm mentioned this issue Aug 23, 2023
Merged
@marstamm
Copy link
Contributor Author

We keep the show/hide API so users can re-create the behavior in case they are experiencing performance problems with very complex overlays

marstamm added a commit that referenced this issue Aug 23, 2023
@marstamm
chore(config): canvas.deferUpdate defaults to false
767e3c3 
closes #798
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Aug 23, 2023
marstamm added a commit that referenced this issue Aug 23, 2023
@marstamm
chore(config): canvas.deferUpdate defaults to false
cba7aa9 
closes #798
marstamm added a commit that referenced this issue Aug 23, 2023
@marstamm
chore(config): canvas.deferUpdate defaults to false
42d0752 
closes #798
@marstamm marstamm mentioned this issue Aug 23, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 23, 2023
nikku pushed a commit that referenced this issue Aug 23, 2023
@marstamm @nikku
chore(config): canvas.deferUpdate defaults to false
e7bc3eb 
closes #798
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 23, 2023
@philippfromme philippfromme mentioned this issue Sep 7, 2023
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: don't hide overlays on canvas move bpmn-io/diagram-js
1 participant
@marstamm