Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't hide overlays on canvas move #799

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

marstamm
Copy link
Contributor

closes #798

@marstamm marstamm requested a review from a team August 23, 2023 08:43
@marstamm marstamm self-assigned this Aug 23, 2023
@marstamm marstamm requested review from philippfromme and smbea and removed request for a team August 23, 2023 08:43
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 23, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@marstamm marstamm force-pushed the 798-show-overlays-on-scroll branch from f66124f to 380348c Compare August 23, 2023 08:46
@nikku nikku changed the title chore: don't hide overlays on canvas move feat: don't hide overlays on canvas move Aug 23, 2023
@nikku
Copy link
Member

nikku commented Aug 23, 2023

This works for me:

npx @bpmn-io/sr bpmn-io/bpmn-js -l bpmn-io/diagram-js#798-show-overlays-on-scroll

I love how it makes the whole diagram interaction less noisy (which is good!):

capture fl0eFl_optimized

@nikku nikku merged commit acd375e into develop Aug 23, 2023
@nikku nikku deleted the 798-show-overlays-on-scroll branch August 23, 2023 09:01
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't hide overlays on canvas move
2 participants