fix(keyboard): only ignore non-modifier events on inputs #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to handle undo, redo and other CTRL/CMD guarded events in a way expected by users.
nikku
requested review from
barmac,
MaxTru and
pinussilvestrus
and removed request for
barmac
MaxTru
approved these changes
Aug 27, 2021
nikku
pushed a commit
that referenced
this pull request
Oct 13, 2021
This reverts #564 to and replaces it with a fine-grained utility to opt-into processing of input-triggered keyboard events. To react to a `CTRL/CMD+` shortcut the input triggering it must be wrapped in a `[input-handle-modified-keys]` directive like so: ```html <div input-handle-modified-keys="z,y"> <input></input> </div> ``` Related to bpmn-io/bpmn-js#1493
nikku
pushed a commit
that referenced
this pull request
Oct 13, 2021
This reverts #564 and replaces it with a fine-grained utility to opt-into processing of input-triggered keyboard events. To react to a `CTRL/CMD+` shortcut the input triggering it must be wrapped in a `[input-handle-modified-keys]` directive like so: ```html <div input-handle-modified-keys="z,y"> <input></input> </div> ``` Related to bpmn-io/bpmn-js#1493
nikku
pushed a commit
that referenced
this pull request
Oct 13, 2021
This reverts #564 and replaces it with a fine-grained utility to opt-into processing of input-triggered keyboard events. To react to a `CTRL/CMD+` shortcut the input triggering it must be wrapped in a `[input-handle-modified-keys]` directive like so: ```html <div input-handle-modified-keys="z,y"> <input></input> </div> ``` Related to bpmn-io/bpmn-js#1493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to handle undo, redo and other CTRL/CMD guarded events in a way expected by users.
Related to bpmn-io/form-js#153 (comment) and likely the safest, most intuitive default behavior.