feat(keyboard): specify which keys are handled #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Oct 12, 2021
marstamm
force-pushed
the
whitelist-modifier-keys
branch
2 times, most recently
from
56f29f1 to
253dc34
Compare
marstamm
force-pushed
the
whitelist-modifier-keys
branch
from
253dc34 to
7e2802a
Compare
bpmn-io-tasks
bot
added
needs review
marstamm
requested review from
a team,
pinussilvestrus and
MaxTru
and removed request for
a team
nikku
force-pushed
the
whitelist-modifier-keys
branch
2 times, most recently
from
0daa945 to
f9ff2d3
Compare
This reverts #564 and replaces it with a fine-grained utility to opt-into processing of input-triggered keyboard events. To react to a `CTRL/CMD+` shortcut the input triggering it must be wrapped in a `[input-handle-modified-keys]` directive like so: ```html <div input-handle-modified-keys="z,y"> <input></input> </div> ``` Related to bpmn-io/bpmn-js#1493
|
Follow-up tasks:
|
I will not integrate it into this editor at this point, as it has unexpected UI effects. The cursor position is reset when we don't use the browser defaults: |
|
@marstamm Makes sense. Let us wait for the first user to find this and report ⌛ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow inputs to define which modifier keys should be handled by the application vs. the browser.
This reverts #564 and replaces it with a fine-grained utility to opt-into processing of input-triggered keyboard events.
To react to a
CTRL/CMD+shortcut the input triggering it must be wrapped in a[input-handle-modified-keys]directive like so:Check bpmn-io/bpmn-properties-panel#135 for usage in the properties panel.
Related to bpmn-io/bpmn-js#1493