contextPad: allow keyboard trigger #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbea
commented
Dec 7, 2022
bpmn-io-tasks
bot
added
in progress
smbea
force-pushed
the
contextpad-allow-keyboard-trigger
branch
3 times, most recently
from
bddc510 to
0004960
Compare
bpmn-io-tasks
bot
added
needs review
smbea
requested review from
nikku,
a team and
marstamm
and removed request for
a team
smbea
changed the title
nikku
reviewed
Dec 7, 2022
smbea
force-pushed
the
contextpad-allow-keyboard-trigger
branch
3 times, most recently
from
c11455c to
7d95852
Compare
nikku
requested changes
Dec 12, 2022
| @@ -294,6 +294,9 @@ Overlays.prototype.remove = function(filter) { | |||
|
|
|||
| }; | |||
|
|
|||
| Overlays.prototype.isShown = function() { | |||
There was a problem hiding this comment.
Please add a test case that verifies the existence of this API.
There was a problem hiding this comment.
You're right, I added it now
There was a problem hiding this comment.
What I was asking for is covering the Overlays#isShown 🙈 (OverlaysSpec or something). Will add the test case now. 👍
There was a problem hiding this comment.
ah sorry, I misread that
There was a problem hiding this comment.
Added another test to verify the newly added ContextPad API, which I renamed to ContextPad#triggerEntry (for clarity).
There was a problem hiding this comment.
We did not return a value anymore from trigger. Fixed + aadded test case to it.
bpmn-io-tasks
bot
added
in progress
smbea
force-pushed
the
contextpad-allow-keyboard-trigger
branch
from
7d95852 to
d44da08
Compare
nikku
force-pushed
the
contextpad-allow-keyboard-trigger
branch
from
01674c6 to
e4e5d7d
Compare
This allows us to understand if overlays are currently shown (or hidden).
Allows manual triggering of entries.
nikku
force-pushed
the
contextpad-allow-keyboard-trigger
branch
from
e4e5d7d to
6d072d0
Compare
nikku
approved these changes
Dec 12, 2022
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bpmn-io/bpmn-js#1785, see bpmn-io/bpmn-js#1785 (comment)