feat(palette): allow trigger with entry id #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows manual triggering of entries.
smbea
requested review from
a team,
philippfromme and
barmac
and removed request for
a team
barmac
approved these changes
Jan 24, 2023
|
You know it's a good PR when you get two approvals 😂 |
19 tasks
|
You got mine because of
Not sure why you got @barmac's 😉 |
|
This makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support bpmn-io/bpmn-js#1814; similar to how we did for context pad #719
I added some general test cases for
#triggersimilar to the ones we have for context pad since we didn't have these for palette