This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
[DOCS] Add contributing to README, and disable vscode autoformat #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdpattern
suggested changes
Nov 28, 2018
|
One more thing, now that I've merged #186, you might want to add a new rule to the .gitignore file... I'm excluding everything in the .vscode except for specific files (currently just the settings.json). I'm OK with inverting the rule to exclude specific files instead... whatever makes it easier to understand... |
|
I just thought of something else... what about moving the contributing section from the README.md to its own CONTRIBUTING.md file? it seems to be a common practice and is even suggested in the insights/community tab |
…mating The vscode autoformatter is completely at odds with prettier, so if you don't have the prettier extension installed, you end up with wild changes.
it is too much to explain installing the extensions, and adding the config, and disabling the beautify extension...
bradzacher
force-pushed
the
fix-settings
branch
from
22b1dba to
3158768
Compare
|
Man github handles rebases weirdly.. I just:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vscode autoformatter is completely at odds with prettier, so if you don't have the prettier extension installed, you end up with wild changes.
Additionally if you've got both the beautify and prettier extensions installed, it can cause some serious issues.
Forcing it to be on will probably cause a lot of headaches to anyone trying to contribute unless they get their environment setup perfectly (sorry @weirdpattern for earlier!!)