Fix wide panels sizes (vert/horz) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change limits the size taken by all BUTTON_WIDGETs when the panel is wide, because for the moment when for example the panel is horizontal 200 pixels wide/high, the widgets take up 200x200 for an icon of max size 48. I've set it to take now (for this example) 50x200 or 200x50 (if it's a vertical panel 200px wide) If users want to leave the same space as before around the icons they just have to move them on the panel anyway and it can be as before.. What I'd like to add after is to get this size (48 or 50) from gsettings by a new option set in the panel properties as 'max_icon_size' or something like that, so that the user decides on the maximum icon size him/herself.
braikar
added a commit
that referenced
this pull request
Aug 20, 2018
This is the end of #2 now the GTK_ARROW is resized properly for wide panel on BUTTON_WIDGETs with property "has_arrow"
braikar
added a commit
that referenced
this pull request
Sep 28, 2018
# This is the 1st commit message: Wide panels (main.c na-gric.c code cleanup) # The commit message #2 will be skipped: # incorrect casts compile warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change limits the size taken by all BUTTON_WIDGETs when the panel is wide, because for the moment when for example the panel is horizontal 200 pixels wide/high, the widgets take up 200x200 for an icon of max size 48.
I've set it to take now (for this example) 50x200 or 200x50 (if it's a vertical panel 200px wide)
If users want to leave the same space as before around the icons they just have to move them on the panel anyway and it can be as before..
What I'd like to add after is to get this size (48 or 50) from gsettings by a new option set in the panel properties as 'max_icon_size' or something like that, so that the user decides on the maximum icon size him/herself.
It still needs some work, the arrow for menus is not updated to correct size yet...