[Desktop] Stop retries if auto contribute or Rewards setting is off

[NejcZdovc]

Right now we check if AC is off only when we start AC process. We should check if AC is off when doing retries as well. We should also check if rewards is off as well.

[mandar-brave]

@NejcZdovc to add to the issue; Monthly contributions should also be turned off immediately when the BR, or M Contributions switch is turned off.

[kjozwiak]

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.12.81 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | macOS Version 10.15.5 (Build 19F101)

Basically ran through the cases that @LaurenWags and @GeetaSarvadnya provided via brave/brave-core#5900 (comment).

Test Case #1 (multiple verified publishers in the a-c table using UGP grant)

• launched using --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6 --rewards=staging=true,reconcile-interval=6,short-retries=true
• enabled rewards and claimed a UGP of 30 BAT
• added three verified publishers into the a-c table before reconcile-interval=6

Disabled a-c via brave://rewards and closed the browser once the a-c process started as per the following:

[19483:775:0709/181922.512886:VERBOSE1:contribution.cc(167)] Staring monthly contribution
[19483:775:0709/181922.515037:VERBOSE1:contribution_ac.cc(32)] Starting auto contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a tip once the a-c as been interrupted/completed

Test Case #2 (multiple verified publishers in the a-c table using KYC wallet)

• launched using --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6 --rewards=staging=true,reconcile-interval=6,short-retries=true
• enabled rewards and logged into a KYC account which had 15 BAT
• added three verified publishers into the a-c table before reconcile-interval=6

Disabled a-c via brave://rewards and closed the browser once the a-c process started as per the following:

[20500:775:0710/000612.454295:VERBOSE1:contribution.cc(170)] Staring monthly contribution
[20500:775:0710/000612.457081:VERBOSE1:contribution_ac.cc(33)] Starting auto contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a tip once the a-c as been interrupted/completed
• Note, full monthly budget was deducted from balance, this is expected per discussions: https://bravesoftware.slack.com/archives/CB0KCRCQN/p1593520104213200?thread_ts=1593519527.212600&cid=CB0KCRCQN and occurs when wallet is a restored anon wallet as well.

Test Case #3 (multiple verified publishers in the a-c table using anon wallet)

• launched using --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6 --rewards=staging=true,reconcile-interval=6,short-retries=true
• enabled rewards and restored an anon wallet
• added three verified publishers into the a-c table before reconcile-interval=6

Disabled a-c via brave://rewards and closed the browser once the a-c process started as per the following:

[20698:775:0710/002037.564818:VERBOSE1:contribution.cc(170)] Staring monthly contribution
[20698:775:0710/002037.566922:VERBOSE1:contribution_ac.cc(33)] Starting auto contribution

[20698:775:0710/002037.564818:VERBOSE1:contribution.cc(170)] Staring monthly contribution
[20698:775:0710/002037.566922:VERBOSE1:contribution_ac.cc(33)] Starting auto contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a tip once the a-c as been interrupted/completed

Test Case #4 (multiple verified publishers + recurring tips using UGP grant)

• launched using --enable-logging=stderr --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6 --rewards=staging=true,reconcile-interval=6,short-retries=true
• enabled rewards and claimed a UGP of 30 BAT
• added four verified publishers into the a-c table and three recurring tips before reconcile-interval=6

Disabled a-c via brave://rewards and closed the browser once the a-c process started as per the following:

[20860:775:0710/003443.379377:VERBOSE1:contribution.cc(170)] Staring monthly contribution
[20860:775:0710/003443.382980:VERBOSE1:contribution_ac.cc(33)] Starting auto contribution
[20860:775:0710/003445.398179:VERBOSE1:contribution.cc(400)] Creating contribution(blinded) for 0 type RewardsType::RECURRING_TIP

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured that the recurring tips completed once the browser was restarted and a-c didn't complete
• ensured you can send a tip once the a-c as been interrupted/completed

Test Case #5 (multiple verified publishers + recurring tips using KYC account)

Basically went through the same steps as Test Case #4 but used a KYC wallet rather than a UGP grant.

Test Case #6 (multiple verified publishers + recurring tips using anon account)

Basically went through the same steps as Test Case #4 but used a anon wallet rather than a UGP grant.

---

Verification passed on

Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

• Verified the test plan from Do not retry if rewards is off or AC is off brave-core#5900 (comment).

Test Case #1 (multiple verified publishers in the a-c table using UGP grant)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console

[6668:11856:0710/182534.776:VERBOSE1:contribution.cc(758)] AC is disabled, completing contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed
  

Test Case #2 (multiple verified publishers in the a-c table using KYC wallet)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console

[5936:7644:0710/195544.780:VERBOSE1:contribution.cc(758)] AC is disabled, completing contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
  
  
  
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed
  

Test Case #3 (multiple verified publishers in the a-c table using anon wallet)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console

[7832:2180:0710/221813.215:VERBOSE1:contribution.cc(758)] AC is disabled, completing contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
  
  
  
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed
  

Test Case #4 (multiple verified publishers + recurring tips using UGP grant)

Disabled a-c via brave://rewards and closed the browser once the a-c process started as per the following:

[3432:14584:0710/223340.361:VERBOSE1:contribution.cc(167)] Staring monthly contribution
[3432:14584:0710/223340.362:VERBOSE1:contribution.cc(264)] Timer will start in 15
[3432:14584:0710/223340.363:VERBOSE1:contribution_ac.cc(32)] Starting auto contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
  
  
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed

Test Case #5 (multiple verified publishers + recurring tips using KYC account)

Basically went through the same steps as Test Case #4 but used a KYC wallet rather than a UGP grant.

-Disabled a-c via brave://rewards and closed the browser once the a-c process started as per the following:

[18376:15712:0710/225258.340:VERBOSE1:contribution.cc(167)] Staring monthly contribution
[18376:15712:0710/225258.342:VERBOSE1:contribution.cc(264)] Timer will start in 23
[18376:15712:0710/225258.342:VERBOSE1:contribution_ac.cc(32)] Starting auto contribution

Test Case #6 (multiple verified publishers + recurring tips using anon account)

Basically went through the same steps as Test Case #4 but used a anon wallet rather than a UGP grant.

---

Verification passed on

Brave	1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Do not retry if rewards is off or AC is off brave-core#5900 (comment).

Steps

Test Case #1 (multiple verified publishers in the a-c table using UGP grant)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console

[2630:2630:0715/175043.792212:VERBOSE1:contribution.cc(758)] AC is disabled, completing contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed
  

Test Case #2 (multiple verified publishers in the a-c table using KYC wallet)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console

[6077:6077:0715/183310.772433:VERBOSE1:contribution.cc(758)] AC is disabled, completing contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed

Test Case #3 (multiple verified publishers in the a-c table using anon wallet)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console

[6974:6974:0715/185135.477992:VERBOSE1:contribution.cc(758)] AC is disabled, completing contribution

• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed

Test Case #4 (multiple verified publishers + recurring tips using UGP grant)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console
  
• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed

Test Case #5 (multiple verified publishers + recurring tips using KYC account)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console
• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed

Test Case #6 (multiple verified publishers + recurring tips using anon account)

• When the AC is OFF and the browser is restarted following logs are recorded in logs in the console
• ensured contribution_info, contribution_info_publisher and unblinded_tokens tables had the correct information/values
• ensured you can send a one time tip and recurring tips once the a-c as been interrupted, recurring tips are processed