Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry if rewards is off or AC is off (uplift to 1.11.x) #5929

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 24, 2020

Uplift of #5900
Resolves brave/brave-browser#10257

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.11.x - Beta milestone Jun 24, 2020
@NejcZdovc NejcZdovc requested a review from a team June 24, 2020 11:26
@NejcZdovc NejcZdovc self-assigned this Jun 24, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #5900 (comment). As per @NejcZdovc, brave/brave-browser#10522 isn't an issue in 1.11.x and only affects 1.12.x.

@kjozwiak kjozwiak merged commit 46664f2 into 1.11.x Jun 30, 2020
@kjozwiak kjozwiak deleted the ac-retry-11 branch June 30, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants