Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on Additional settings isn't expanding/collapsing the settings in brave://settings/safetyCheck page #14065

Closed
GeetaSarvadnya opened this issue Feb 9, 2021 · 1 comment · Fixed by brave/brave-core#7900

Comments

@GeetaSarvadnya
Copy link

Description

Click on Additional settings isn't expanding/collapsing the settings in brave://settings/safetyCheck page

Steps to Reproduce

  1. Clean or upgraded profile 1.22.x
  2. Open brave://settings/safetyCheck page
  3. Click on Additional settings
  4. Click on Additional settings isn't expanding/collapsing the settings in brave://settings/safetyCheck page

Actual result:

Click on Additional settings isn't expanding/collapsing the settings in brave://settings/safetyCheck page
Additional settings

Expected result:

Click on Additional settings should expanding/collapsing the settings in brave://settings/safetyCheck page

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.22.9 Chromium: 89.0.4389.40 (Official Build) nightly (64-bit)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS Windows 10 OS Version 2004 (Build 19041.746)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bbondy

mkarolin added a commit to brave/brave-core that referenced this issue Feb 9, 2021
Adds missing toolbar functions and removes no longer needed ones that we
removed from cr_toolbar.

Fixes brave/brave-browser#14065
@mkarolin mkarolin self-assigned this Feb 9, 2021
@mkarolin mkarolin added this to the 1.22.x - Nightly milestone Feb 11, 2021
@stephendonner
Copy link

stephendonner commented Feb 18, 2021

Verified FIXED using nightly build

Brave 1.22.34 Chromium: 89.0.4389.48 (Official Build) nightly (x86_64)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS macOS Version 11.2.1 (Build 20D74)

Steps:

  1. opened brave://settings/safetyCheck
  2. clicked on the triangle to the right of the Additional settings link, center-bottom
  3. verified that the panel can be expanded/collapsed, and is collapsed, by default
    additional-settings

Verification passed using the nightly build

Brave | 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Steps:

  1. opened brave://settings/safetyCheck
  2. clicked on the triangle to the right of the Additional settings link, center-bottom
  3. verified that the panel can be expanded/collapsed, and is collapsed, by default

Verification passed on

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment