Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] fixes clicking 'Additional settings'. #7900

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 9, 2021

Adds missing toolbar functions and removes no longer needed ones that we
removed from cr_toolbar.

Fixes brave/brave-browser#14065

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Adds missing toolbar functions and removes no longer needed ones that we
removed from cr_toolbar.

Fixes brave/brave-browser#14065
@mkarolin mkarolin requested a review from bbondy February 9, 2021 19:00
@mkarolin mkarolin self-assigned this Feb 9, 2021
@mkarolin mkarolin requested a review from petemill February 9, 2021 20:52
@mkarolin mkarolin merged commit f108531 into master Feb 11, 2021
@mkarolin mkarolin deleted the maxk-fix-additional-settings branch February 11, 2021 16:28
@mkarolin mkarolin added this to the 1.22.x - Nightly milestone Feb 11, 2021
mkarolin added a commit that referenced this pull request Feb 11, 2021
[Settings] fixes clicking 'Additional settings'.
mkarolin added a commit that referenced this pull request Feb 16, 2021
[Settings] fixes clicking 'Additional settings'.
mkarolin added a commit that referenced this pull request Feb 19, 2021
[Settings] fixes clicking 'Additional settings'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on Additional settings isn't expanding/collapsing the settings in brave://settings/safetyCheck page
2 participants