-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double separator line when you can "send to Google phone" #15714
Labels
Milestone
Comments
On Chrome the next menu item is |
Now (1.27.4) I see the space between two separators is supposed to correspond the Chrome |
24 tasks
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
May 25, 2021
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
May 31, 2021
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
Jun 9, 2021
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
Jun 9, 2021
This also removes duplicated menu separator after remove translate menu item fixes brave/brave-browser#15714
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
Jun 10, 2021
fixes brave/brave-browser#15714 RemoveAdjacentSeparators::RenderViewContextMenuBase is used
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
Jun 10, 2021
fixes brave/brave-browser#15714 RemoveAdjacentSeparators::RenderViewContextMenuBase is used
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
Jun 15, 2021
fixes brave/brave-browser#15714 RemoveAdjacentSeparators::RenderViewContextMenuBase is used
AlexeyBarabash
added a commit
to brave/brave-core
that referenced
this issue
Jun 16, 2021
fixes brave/brave-browser#15714 Override of RenderViewContextMenuViews::Show is used
Verified
Steps:
Confirmed it's now:
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Hi, if you connect the sync to an android, you can use the "send to google phone" feature. This shows 2 separators in the right click menu under that.
I don't know the condition for the feature since it didn't show up right away
Steps to Reproduce
Actual result:
Expected result:
only one seperator without the empty space in that
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
1.24.82 Chromium: 90.0.4430.93 64-Bit
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: