Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double separator line when you can "send to Google phone" #15714

Closed
xopez opened this issue May 10, 2021 · 4 comments · Fixed by brave/brave-core#8914
Closed

Double separator line when you can "send to Google phone" #15714

xopez opened this issue May 10, 2021 · 4 comments · Fixed by brave/brave-core#8914

Comments

@xopez
Copy link

xopez commented May 10, 2021

Description

Hi, if you connect the sync to an android, you can use the "send to google phone" feature. This shows 2 separators in the right click menu under that.
I don't know the condition for the feature since it didn't show up right away

Steps to Reproduce

  1. Add sync between Desktop and Android
  2. Right click on any page

Actual result:

image

Expected result:

only one seperator without the empty space in that

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.24.82 Chromium: 90.0.4430.93 64-Bit

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No (already disabled)
  • Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

@AlexeyBarabash
Copy link
Contributor

On Chrome the next menu item is Create QR code for this page which is cut in Brave.

@stephendonner
Copy link

This happens on desktop, too, but isn't always broken. It depends on the content for the context-menu invocation.

broken works
broken-desktop not-always-broken

@AlexeyBarabash AlexeyBarabash self-assigned this May 20, 2021
@AlexeyBarabash
Copy link
Contributor

Now (1.27.4) I see the space between two separators is supposed to correspond the Chrome Translate to English menu item.

AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jun 9, 2021
This also removes duplicated menu separator after remove translate menu item

fixes brave/brave-browser#15714
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jun 10, 2021
fixes brave/brave-browser#15714

RemoveAdjacentSeparators::RenderViewContextMenuBase is used
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jun 10, 2021
fixes brave/brave-browser#15714

RemoveAdjacentSeparators::RenderViewContextMenuBase is used
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jun 15, 2021
fixes brave/brave-browser#15714

RemoveAdjacentSeparators::RenderViewContextMenuBase is used
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jun 16, 2021
fixes brave/brave-browser#15714

Override of RenderViewContextMenuViews::Show is used
@AlexeyBarabash AlexeyBarabash added this to the 1.28.x - Nightly milestone Jun 18, 2021
@stephendonner
Copy link

stephendonner commented Jun 22, 2021

Verified PASSED using

Brave 1.28.20 Chromium: 91.0.4472.114 (Official Build) nightly (x86_64)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. set up Sync chain view brave://settings/braveSync
  2. join chain using either desktop Brave or iOS/Android Brave
  3. on desktop, context-click on any page
  4. look at the context-menu options

Confirmed it's now:

-----------------------------
Send to Your Devices >
Create QR code for this Page
-----------------------------

Screen Shot 2021-06-22 at 9 56 02 AM


Verification passed on

Brave 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Ubuntu 18.04 LTS
image image

Verification passed on


Brave | 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | Windows 10 OS Version 2004 (Build 19041.1110)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment