Remove duplicated menu separator after remove translate menu item

fixes brave/brave-browser#15714
brave · Jun 9, 2021 · 6d4a593 · 6d4a593
1 parent 1e48647
commit 6d4a593
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -323,7 +323,20 @@ void BraveRenderViewContextMenu::InitMenu() {
   // Only show the translate item when go-translate is enabled.
 #if !BUILDFLAG(ENABLE_BRAVE_TRANSLATE_GO)
   index = menu_model_.GetIndexOfCommandId(IDC_CONTENT_CONTEXT_TRANSLATE);
-  if (index != -1)
+  if (index != -1) {
     menu_model_.RemoveItemAt(index);
+
+    // Separator always precedes translate item,
+    // see RenderViewContextMenu::AppendPageItems.
+    // Remove separator if it is duplicated by any reason.
+    if (index < menu_model_.GetItemCount() &&
+        menu_model_.GetTypeAt(index) ==
+            ui::MenuModel::ItemType::TYPE_SEPARATOR &&
+        index > 0 &&
+        menu_model_.GetTypeAt(index - 1) ==
+            ui::MenuModel::ItemType::TYPE_SEPARATOR) {
+      menu_model_.RemoveItemAt(index);
+    }
+  }
 #endif
 }