Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Bravenews settings header #12817

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#21725
Resolves brave/brave-browser#21833

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 29, 2022
@tapanmodh tapanmodh self-assigned this Mar 29, 2022
@tapanmodh tapanmodh added this to the 1.38.x - Beta milestone Mar 29, 2022
Copy link
Contributor

@alexsafe alexsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya
Copy link
Contributor

Thank you @tapanmodh for fixing these issues.

@tapanmodh tapanmodh merged commit 9478b3c into master Mar 31, 2022
@tapanmodh tapanmodh deleted the bravenews_settings_header_fix_android branch March 31, 2022 05:17
brave-builds pushed a commit that referenced this pull request Apr 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Moving into 1.39.x as this landed in master ~8 days ago which was 1.39.x and not 1.38.x. These fixes are not in 1.38.x until #12931 as been uplifted into 1.38.x.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Reproduced both brave/brave-browser#21725 & brave/brave-browser#21833 using 1.37.110 Chromium: 100.0.4896.60.

Verification PASSED on Pixel 6 running Android 12 using 1.39.41 Chromium: 100.0.4896.79

Test Case #1 - brave/brave-browser#21725

Went through the STR/Cases outlined via brave/brave-browser#21725 (comment) as per the following:

screen-20220408-001254.mp4

Test Case #2 - Brave News header missing when interrupting page load by tapping Home button #21833

Went through the STR/Cases outlined via brave/brave-browser#21725 (comment) as per the following:

screen-20220408-001805.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
4 participants