Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.43.x (Chromium 105) #25050

Closed
mkarolin opened this issue Aug 29, 2022 · 4 comments · Fixed by brave/brave-core#14870
Closed

Update l10n for 1.43.x (Chromium 105) #25050

mkarolin opened this issue Aug 29, 2022 · 4 comments · Fixed by brave/brave-core#14870

Comments

@mkarolin
Copy link
Contributor

Download the latest l10n from Transifex.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 30, 2022

Verification PASSED using

Brave | 1.43.84 Chromium: 105.0.5195.68 (Official Build) (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Filed: #25082

Hindi

Welcome Close All Tabs BR Panel Rewards NTP Settings
image 1 image 1 image 1 image 1 image 1 image 1

Portuguese

Welcome Close All Tabs BR Panel Rewards NTP Settings
image 1 image 1 image 1 image 1 NTP image 1

German

Welcome Close All Tabs BR Panel Rewards NTP Settings
image 1 image 1 image 1 image 1 image 1 image 1

Korean

Welcome Close All Tabs BR Panel Rewards NTP Settings
image 1 image 1 image 1 image 1 image 1 image 1

@kjozwiak
Copy link
Member

@MadhaviSeelam the above still hasn't been uplifted/merged into 1.43.x. Just uplifted it via brave/brave-core#14878 and will kick off new 1.43.x RC builds tonight.

The above requires 1.43.84 or higher for 1.43.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 1, 2022

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using build version:

Brave	1.43.88 Chromium: 105.0.5195.68 (Official Build) (64-bit) 
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Android 12; Build/SP1A.210812.016

French (Locale: France)

VPN Split Tunnel Split Tunnel VPN
screenshot-1662041453181 screenshot-1662041870918 screenshot-1662041879421 screenshot-1662041889828
NTP/Context Menu Tips Welcome Welcome
screenshot-1662041926921 screenshot-1662041282879 screenshot-1662041786798 screenshot-1662041267673
Menu Settings Rewards Rewards
screenshot-1662041319076 screenshot-1662042924686 screenshot-1662041958004 screenshot-1662041721903

Russian (Locale: Ukraine)

Split Tunnel/VPN

Example Example Example
screenshot-1662044040271 screenshot-1662044077016 screenshot-1662044083565

Sync

Example Example Example Example Example
screenshot-1662043563093 screenshot-1662043569219 screenshot-1662043599085 screenshot-1662043614147 screenshot-1662043624137

Stats/Privay Report

Example Example
screenshot-1662043522791 screenshot-1662043528634

Brave News

Example Example Example
screenshot-1662043466036 screenshot-1662043474467 screenshot-1662043510112

Spanish (Locale: Mexico)

Welcome / Tool Tips

Example Example Example Example Example Example
screenshot-1662046336120 screenshot-1662046341060 screenshot-1662046345532 screenshot-1662046353200 screenshot-1662046365631 screenshot-1662046396014

Bookmark modals

Example Example Example
screenshot-1662046420450 screenshot-1662046430951 screenshot-1662046441628

Brave Wallet Portfolio / Settings

Example Example Example Example
screenshot-1662046522774 screenshot-1662046533465 screenshot-1662046541044 screenshot-1662046560521

Split Tunneling

Example Example Example
screenshot-1662047175165 screenshot-1662047184618 screenshot-1662047191034

@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2022

Just a quick note that translations were also checked for both the new Onboarding for India and the Brave Search promo via #24111 (comment) & #23062 (comment) on both Phones & Tablets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants