Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab title for brave://welcome reads Chromium instead of Brave in Hindi #25082

Closed
MadhaviSeelam opened this issue Aug 30, 2022 · 2 comments · Fixed by brave/brave-core#14907
Closed

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 30, 2022

Description

Found while testing #25050
Tab title for Welcome to Brave reads as chromium instead of Brave in Hindi

Steps to Reproduce

  1. Install 1.43.84
  2. Set OS locales to Hindi
  3. Launch Brave
  4. Notice the tab title for brave://welcome

Actual result:

Tab title for brave://welcome reads Chromium in Hindi
image

Expected result:

Should read Brave

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.43.84 Chromium: 105.0.5195.68 (Official Build) (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @brave/qa-team

@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above requires 1.43.91 or higher for 1.43.x verification 👍

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Sep 8, 2022

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Verified using original STR from #25082 (comment)

Confirmed correct tab title (Brave) shown in Hindi

Ex1 Ex2
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants