Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Search Engine Default Promo #23062

Closed
timchilds opened this issue May 25, 2022 · 2 comments · Fixed by brave/brave-core#14350
Closed

[Android] Search Engine Default Promo #23062

timchilds opened this issue May 25, 2022 · 2 comments · Fixed by brave/brave-core#14350

Comments

@timchilds
Copy link

timchilds commented May 25, 2022

Spec
https://bravesoftware.slack.com/archives/C02SC5AKTAS/p1653579929433229

@kjozwiak
Copy link
Member

STR/Cases for @brave/qa-team can be found via brave/brave-core#14350 (comment) & brave/brave-core#14350 (comment).

@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2022

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016

Test Case #1 (Supported Regions - US/CA/DE/FR/UK/AT/ES/MX)

  • installed 1.43.87 Chromium: 105.0.5195.68
  • ensured that the system language is set to either US, CA, DE, FR, UK, AT, ES or MX
  • launched brave and changed the default SE from Brave to anything else within the list (Google, DDG, Startpage etc..)
  • added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
  • re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
  • ensured that the Brave search promo appears when tapping/editing a URL and the promo hasn't been closed/dismissed
  • ensured that the Brave search promo doesn't appear if Private is set to another SE but Standard is still selected as Brave
  • ensured that tapping on Maybe Later closes the promo within the omnibox and doesn't appear again within the session
    • ensured that it doesn't appear via the omnibox via NTP when starting to enter a URL/search term
    • ensured that tapping on a URL in an existing tab doesn't display the promo
  • ensured that tapping on Try Brave Search opens https://search.brave.com/search?q=motorsport&action=makeDefault
    • ensured that the search term is also appended as per search?q=motorsport
    • ensured that tapping on Try Brave Search adds action=makeDefault into the URL

Germany

Example Example Example Example Example Example
Screenshot_20220901-010515_Brave Screenshot_20220901-010620_Brave Screenshot_20220901-010634_Brave Screenshot_20220901-010715_Brave Screenshot_20220901-010738_Brave Screenshot_20220901-010747_Brave

UK

Example Example Example Example Example Example
Screenshot_20220901-012036_Brave Screenshot_20220901-012110_Brave Screenshot_20220901-012120_Brave Screenshot_20220901-012159_Brave Screenshot_20220901-012214_Brave Screenshot_20220901-012220_Brave

Test Case #2 (Regions that don't have Brave Search as default SE/Still use SE onboarding)

  • installed 1.43.87 Chromium: 105.0.5195.68
  • ensured that the system language is set to the correct locale (in this case, Poland)
  • launched brave and added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
  • re-launched the browser tapped on the URL bar twice and ensured that the SE onboarding screen is displayed
  • ensured that Google was selected as the default via the onboarding screen
  • ensured that Google is default SE for both Standard & Private windows once the onboarding screen has been dismissed
  • ensured that the Brave search promo isn't appearing via the omnibox when a text/search term is entered

Poland

Example Example Example Example
Screenshot_20220901-013337_Brave Screenshot_20220901-013349_Brave Screenshot_20220901-013400_Brave Screenshot_20220901-013407_Brave

Test Case #3 (Maybe Later & Dismiss)

  • ensured that closing the Brave search promo via Maybe Later doesn't re-appear in the same session
    • ensure the promo is not re-appearing when typing into the omnibox via NTP
    • ensure the promo is not re-appearing when taping on a URL on an existing opened tab
  • ensured that the promo re-appears again when the browser is re-launched after tapping on Maybe Later
  • ensured that once a user taps/clicks on Dismiss, the promo never re-appears (tried via several re-launches)
Example Example Example Example
Screenshot_20220901-012942_Brave Screenshot_20220901-012946_Brave Screenshot_20220901-012955_Brave Screenshot_20220901-012958_Brave

Test Case #4 (Automatically dismiss after 15 days)

  • installed 1.43.87 Chromium: 105.0.5195.68
  • ensured that the system language is set to either US, CA, DE, FR, UK, AT, ES or MX
  • launched brave and changed the default SE from Brave to anything else within the list (Google, DDG, Startpage etc..)
  • added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
  • re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
  • moved the time/date on the device ahead ~16 days and re-launched the browser
  • ensured that the Brave search promo doesn't appear via the omnibox when tapping via NTP
  • ensured that the Brave search promo doesn't appear when tapping on the omnibox if an already opened tab

Verification PASSED on Samsung Tab S8 Ultra running Android 12 using the following build(s):

Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016

Test Case #1 (Supported Regions - US/CA/DE/FR/UK/AT/ES/MX)

  • installed 1.43.87 Chromium: 105.0.5195.68
  • ensured that the system language is set to either US, CA, DE, FR, UK, AT, ES or MX
  • launched brave and changed the default SE from Brave to anything else within the list (Google, DDG, Startpage etc..)
  • added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
  • re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
  • ensured that the Brave search promo appears when tapping/editing a URL and the promo hasn't been closed/dismissed
  • ensured that the Brave search promo doesn't appear if Private is set to another SE but Standard is still selected as Brave
  • ensured that tapping on Maybe Later closes the promo within the omnibox and doesn't appear again within the session
    • ensured that it doesn't appear via the omnibox via NTP when starting to enter a URL/search term
    • ensured that tapping on a URL in an existing tab doesn't display the promo
  • ensured that tapping on Try Brave Search opens https://search.brave.com/search?q=motorsport&action=makeDefault
    • ensured that the search term is also appended as per search?q=motorsport
    • ensured that tapping on Try Brave Search adds action=makeDefault into the URL

France

Example Example Example Example Example Example
Screenshot_20220901_034643_Brave Screenshot_20220901_034756_Brave Screenshot_20220901_034808_Brave Screenshot_20220901_034917_Brave Screenshot_20220901_035016_Brave Screenshot_20220901_035025_Brave

Test Case #2 (Regions that don't have Brave Search as default SE/Still use SE onboarding)

  • installed 1.43.87 Chromium: 105.0.5195.68
  • ensured that the system language is set to the correct locale (in this case, Romania)
  • launched brave and added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
  • re-launched the browser tapped on the URL bar twice and ensured that the SE onboarding screen is displayed
  • ensured that Google was selected as the default via the onboarding screen
  • ensured that Google is default SE for both Standard & Private windows once the onboarding screen has been dismissed
  • ensured that the Brave search promo isn't appearing via the omnibox when a text/search term is entered

Romania

Example Example Example Example
Screenshot_20220901_035807_Brave Screenshot_20220901_035820_Brave Screenshot_20220901_035834_Brave Screenshot_20220901_035842_Brave

Test Case #3 (Maybe Later & Dismiss)

  • ensured that closing the Brave search promo via Maybe Later doesn't re-appear in the same session
    • ensure the promo is not re-appearing when typing into the omnibox via NTP
    • ensure the promo is not re-appearing when taping on a URL on an existing opened tab
  • ensured that the promo re-appears again when the browser is re-launched after tapping on Maybe Later
  • ensured that once a user taps/clicks on Dismiss, the promo never re-appears (tried via several re-launches)
Example Example Example Example
Screenshot_20220901_035318_Brave Screenshot_20220901_035322_Brave Screenshot_20220901_035341_Brave Screenshot_20220901_035345_Brave

Test Case #4 (Automatically dismiss after 15 days)

  • installed 1.43.87 Chromium: 105.0.5195.68
  • ensured that the system language is set to either US, CA, DE, FR, UK, AT, ES or MX
  • launched brave and changed the default SE from Brave to anything else within the list (Google, DDG, Startpage etc..)
  • added --enable-features=BraveSearchOmniboxBanner into Command Line String via QA Preferences
  • re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
  • moved the time/date on the device ahead ~16 days and re-launched the browser
  • ensured that the Brave search promo doesn't appear via the omnibox when tapping via NTP
  • ensured that the Brave search promo doesn't appear when tapping on the omnibox if an already opened tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment