-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Search Engine Default Promo #23062
Labels
Brave Search
feature/search
OS/Android
Fixes related to Android browser functionality
QA Pass - Android ARM
QA Pass - Android Tab
QA/Test-All-Device-Types
QA/Yes
release-notes/exclude
Milestone
Comments
25 tasks
7 tasks
STR/Cases for @brave/qa-team can be found via brave/brave-core#14350 (comment) & brave/brave-core#14350 (comment). |
Verification PASSED on
|
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
UK
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Test Case #2
(Regions that don't have Brave Search as default SE/Still use SE onboarding)
- installed
1.43.87 Chromium: 105.0.5195.68
- ensured that the system language is set to the correct locale (in this case,
Poland
) - launched brave and added
--enable-features=BraveSearchOmniboxBanner
intoCommand Line String
viaQA Preferences
- re-launched the browser tapped on the URL bar twice and ensured that the SE onboarding screen is displayed
- ensured that Google was selected as the default via the onboarding screen
- ensured that Google is default SE for both
Standard
&Private
windows once the onboarding screen has been dismissed - ensured that the Brave search promo isn't appearing via the omnibox when a text/search term is entered
Poland
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Test Case #3
(Maybe Later & Dismiss)
- ensured that closing the Brave search promo via
Maybe Later
doesn't re-appear in the same session- ensure the promo is not re-appearing when typing into the omnibox via NTP
- ensure the promo is not re-appearing when taping on a URL on an existing opened tab
- ensured that the promo re-appears again when the browser is re-launched after tapping on
Maybe Later
- ensure that the
Dismiss
button is visible and not theMaybe Later
as per omnibox brave search promo banner android brave-core#14350 (comment)
- ensure that the
- ensured that once a user taps/clicks on
Dismiss
, the promo never re-appears (tried via several re-launches)
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Test Case #4
(Automatically dismiss after 15 days)
- installed
1.43.87 Chromium: 105.0.5195.68
- ensured that the system language is set to either
US
,CA
,DE
,FR
,UK
,AT
,ES
orMX
- launched brave and changed the default SE from
Brave
to anything else within the list (Google, DDG, Startpage etc..) - added
--enable-features=BraveSearchOmniboxBanner
intoCommand Line String
viaQA Preferences
- re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
- moved the time/date on the device ahead ~16 days and re-launched the browser
- ensured that the Brave search promo doesn't appear via the omnibox when tapping via NTP
- ensured that the Brave search promo doesn't appear when tapping on the omnibox if an already opened tab
Verification PASSED on Samsung Tab S8 Ultra
running Android 12
using the following build(s):
Brave | 1.43.87 Chromium: 105.0.5195.68 (Official Build) (32-bit)
--- | ---
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Android 12; Build/SP1A.210812.016
Test Case #1
(Supported Regions - US/CA/DE/FR/UK/AT/ES/MX)
- installed
1.43.87 Chromium: 105.0.5195.68
- ensured that the system language is set to either
US
,CA
,DE
,FR
,UK
,AT
,ES
orMX
- launched brave and changed the default SE from
Brave
to anything else within the list (Google, DDG, Startpage etc..) - added
--enable-features=BraveSearchOmniboxBanner
intoCommand Line String
viaQA Preferences
- re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
- ensured that the Brave search promo appears when tapping/editing a URL and the promo hasn't been closed/dismissed
- ensured that the Brave search promo doesn't appear if
Private
is set to another SE butStandard
is still selected asBrave
- ensured that tapping on
Maybe Later
closes the promo within the omnibox and doesn't appear again within the session- ensured that it doesn't appear via the omnibox via NTP when starting to enter a URL/search term
- ensured that tapping on a URL in an existing tab doesn't display the promo
- ensured that tapping on
Try Brave Search
openshttps://search.brave.com/search?q=motorsport&action=makeDefault
- ensured that the search term is also appended as per
search?q=motorsport
- ensured that tapping on
Try Brave Search
addsaction=makeDefault
into the URL
- ensured that the search term is also appended as per
France
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Test Case #2
(Regions that don't have Brave Search as default SE/Still use SE onboarding)
- installed
1.43.87 Chromium: 105.0.5195.68
- ensured that the system language is set to the correct locale (in this case,
Romania
) - launched brave and added
--enable-features=BraveSearchOmniboxBanner
intoCommand Line String
viaQA Preferences
- re-launched the browser tapped on the URL bar twice and ensured that the SE onboarding screen is displayed
- ensured that Google was selected as the default via the onboarding screen
- ensured that Google is default SE for both
Standard
&Private
windows once the onboarding screen has been dismissed - ensured that the Brave search promo isn't appearing via the omnibox when a text/search term is entered
Romania
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Test Case #3
(Maybe Later & Dismiss)
- ensured that closing the Brave search promo via
Maybe Later
doesn't re-appear in the same session- ensure the promo is not re-appearing when typing into the omnibox via NTP
- ensure the promo is not re-appearing when taping on a URL on an existing opened tab
- ensured that the promo re-appears again when the browser is re-launched after tapping on
Maybe Later
- ensure that the
Dismiss
button is visible and not theMaybe Later
as per omnibox brave search promo banner android brave-core#14350 (comment)
- ensure that the
- ensured that once a user taps/clicks on
Dismiss
, the promo never re-appears (tried via several re-launches)
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Test Case #4
(Automatically dismiss after 15 days)
- installed
1.43.87 Chromium: 105.0.5195.68
- ensured that the system language is set to either
US
,CA
,DE
,FR
,UK
,AT
,ES
orMX
- launched brave and changed the default SE from
Brave
to anything else within the list (Google, DDG, Startpage etc..) - added
--enable-features=BraveSearchOmniboxBanner
intoCommand Line String
viaQA Preferences
- re-launched the browser tapped on the URL bar and ensured that the Brave search promo is displayed via the omnibox
- moved the time/date on the device ahead ~16 days and re-launched the browser
- ensured that the Brave search promo doesn't appear via the omnibox when tapping via NTP
- ensured that the Brave search promo doesn't appear when tapping on the omnibox if an already opened tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Brave Search
feature/search
OS/Android
Fixes related to Android browser functionality
QA Pass - Android ARM
QA Pass - Android Tab
QA/Test-All-Device-Types
QA/Yes
release-notes/exclude
Spec
https://bravesoftware.slack.com/archives/C02SC5AKTAS/p1653579929433229
The text was updated successfully, but these errors were encountered: