Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Add localization for file transaction info #16888

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#26136

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to send page
  2. Select Filecoin, enter amount, select to account and click on "Review order"
  3. In the transaction confirmation screen, the transaction info labels should be the same as before.

Screenshot 2023-01-27 at 14 10 03

@muliswilliam muliswilliam requested review from a team as code owners January 27, 2023 11:13
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 27, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@muliswilliam muliswilliam force-pushed the fix-add-localization-for-gas-titles branch 2 times, most recently from 791fe8c to 58bbba4 Compare February 23, 2023 08:10
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam force-pushed the fix-add-localization-for-gas-titles branch from 58bbba4 to a155388 Compare February 23, 2023 20:22
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit 9c36ad8 into master Feb 24, 2023
@muliswilliam muliswilliam deleted the fix-add-localization-for-gas-titles branch February 24, 2023 07:20
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add localisation for gas titles
4 participants