Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Wrap Long NFT Names in Send #16460

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where long NFT names were not wrapping in the Send tab.

Resolves brave/brave-browser#27521

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Add a NFT with a really long name
  2. Go to the Send tab and select an NFT to send
  3. The name should be wrapped and not go off the screen.

Before:

Screenshot 2022-12-22 at 9 58 33 AM

After:

Screenshot 2022-12-22 at 10 49 32 AM

@Douglashdaniel Douglashdaniel self-assigned this Dec 22, 2022
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner December 22, 2022 17:07
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 22, 2022
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 6745b6d into master Dec 22, 2022
@Douglashdaniel Douglashdaniel deleted the fix-wallet-wrap-long-nft-names-in-send branch December 22, 2022 20:32
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long NFT Names need to Be Wrapped in Send Tab
3 participants