Enable sharing_hub::kDesktopScreenshots feature #28560

simonhong · 2023-02-16T05:06:59Z

Description

Enable sharing-desktop-screenshots feature by default

With this feature, we can see screenshot menu from sharing hub.

When download the screenshot file from below bubble,
proposed screenshot file name should have brave_ prefix instead of chrome_ prefix.

Test Plan

Feature test

Check that Screenshot is available in the Share menu in the url bar beneath Copy Clean Link and before Send your devices.
Select Screenshot and confirm that a selection cursor is available and you can now select a portion of the browser content window to create a screenshot. Note that screenshot tool does not allow you to select outside of the content window. Also confirm that you can select outside of the window to get out of taking a screenshot.
Create a screenshot from step 2 by selecting content within the content window. Confirm that a screenshot preview is generated and can be downloaded.
Confirm that the screenshot has brave_screenshot pre-appended to the file name and includes the domain name as part of the filename to the png file and can be accessed via the download UI button or brave://downloads/

Flag test

Confirm that brave://flags/#sharing-desktop-screenshots is set to default (enabled).

The text was updated successfully, but these errors were encountered:

fix brave/brave-browser#28560

LaurenWags · 2023-03-20T18:02:34Z

Labelling as QA/Blocked for now, pending additional information/clarification on test plan from @rebron

Current test plan (per description) is:

make sure Screenshot is available from sharing hub
make sure when downloading screenshot the file prefix is "brave_" not "chrome_"

LaurenWags · 2023-03-30T20:12:39Z

Removing QA/Blocked, @rebron updated the test plan in #28560 (comment).

LaurenWags · 2023-03-31T12:54:59Z

Verified with

Brave | 1.50.110 Chromium: 112.0.5615.49 (Official Build) (x86_64)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | macOS Version 12.6.4 (Build 21G526)

Verified test plan from #28560 (comment).

Confirmed that Screenshot is available in the Share menu in the url bar beneath Copy Clean Link and before Send to your devices (if sync enabled and a mobile device is part of sync chain, otherwise this option does not display).
Confirmed when selecting Screenshot a cursor is available and am able to select a portion of the browser content window to create a screenshot.
Confirmed that the screenshot tool does not allow selection outside of the content window.
Confirmed able to get out of screenshot mode by selecting Esc.
- Note, selecting/clicking outside of the window does not get out of screenshot mode as mentioned in the description/test plan. Confirmed this is the same behavior in Chrome with 112.0.5615.49 (Official Build) beta (x86_64). Confirmed this is ok per https://bravesoftware.slack.com/archives/C7VLGSR55/p1680272767922349?thread_ts=1680271939.020979&cid=C7VLGSR55.
Confirmed able to grab a screenshot by selecting content within the content window.
Confirmed that a screenshot preview is generated and can be downloaded.
Confirmed that the screenshot has brave_screenshot pre-appended to the file name and includes the domain name as part of the filename to the png file.
Confirmed the screenshot can be accessed via the download UI button and brave://downloads/
Confirmed the flag is available in brave://flags and default is enabled.
Confirmed able to set flag to disabled and Screenshot does not display in share menu

Example	Example	Example	Example
	https://user-images.githubusercontent.com/28145373/229159436-3e6ed140-6bc2-4c9f-8885-50fef30bfe09.mp4

LaurenWags · 2023-04-03T13:25:58Z

Verified with

Brave	1.50.112 Chromium: 112.0.5615.49 (Official Build) (64-bit) 
Revision	bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS	Linux

Verified test plan from #28560 (comment).

Confirmed that Screenshot is available in the Share menu in the url bar beneath Copy Clean Link and before Send to your devices (if sync enabled and a mobile device is part of sync chain, otherwise this option does not display).
Confirmed when selecting Screenshot a cursor is available and am able to select a portion of the browser content window to create a screenshot.
Confirmed that the screenshot tool does not allow selection outside of the content window.
Confirmed able to get out of screenshot mode by selecting Esc.
- Note, selecting/clicking outside of the window does not get out of screenshot mode as mentioned in the description/test plan. Confirmed this is the same behavior in Chrome with 112.0.5615.49 (Official Build) beta (x86_64). Confirmed this is ok per https://bravesoftware.slack.com/archives/C7VLGSR55/p1680272767922349?thread_ts=1680271939.020979&cid=C7VLGSR55.
Confirmed able to grab a screenshot by selecting content within the content window.
Confirmed that a screenshot preview is generated and can be downloaded.
Confirmed that the screenshot has brave_screenshot pre-appended to the file name and includes the domain name as part of the filename to the png file.
Confirmed the screenshot can be accessed via the download UI button and brave://downloads/
Confirmed the flag is available in brave://flags and default is enabled.
Confirmed able to set flag to disabled and Screenshot does not display in share menu

Example	Example	Example	Example	Example
	https://user-images.githubusercontent.com/28145373/229541241-4a9a12eb-eff2-4298-8300-276dc6f19859.mp4

stephendonner · 2023-04-03T17:22:33Z

Verification `PASSED` using

Brave	1.50.112 Chromium: 112.0.5615.49 (Official Build) (64-bit)
Revision	bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}

Verified test plan from #28560 (comment).

Confirmed that Screenshot is available in the Share menu in the url bar beneath Copy Clean Link and before Send to your devices (if sync enabled and a mobile device is part of sync chain, otherwise this option does not display).
Confirmed when selecting Screenshot a cursor is available and am able to select a portion of the browser content window to create a screenshot.
Confirmed that the screenshot tool does not allow selection outside of the content window.
Confirmed able to get out of screenshot mode by selecting Esc.
- Note, selecting/clicking outside of the window does not get out of screenshot mode as mentioned in the description/test plan. Confirmed this is the same behavior in Chrome with 112.0.5615.49 (Official Build) beta (x86_64). Confirmed this is ok per https://bravesoftware.slack.com/archives/C7VLGSR55/p1680272767922349?thread_ts=1680271939.020979&cid=C7VLGSR55.
Confirmed able to grab a screenshot by selecting content within the content window.
Confirmed that a screenshot preview is generated and can be downloaded.
Confirmed that the screenshot has brave_screenshot pre-appended to the file name and includes the domain name as part of the filename to the png file.
Confirmed the screenshot can be accessed via the download UI button and brave://downloads/
Confirmed the flag is available in brave://flags and default is enabled.
Confirmed able to set flag to disabled and Screenshot does not display in share menu

Example	Example	Example	Example	Example

simonhong added QA/Yes release-notes/include OS/Desktop labels Feb 16, 2023

simonhong self-assigned this Feb 16, 2023

simonhong mentioned this issue Feb 16, 2023

Enabled desktop screenshot feature by default brave/brave-core#17252

Merged

25 tasks

simonhong added a commit to brave/brave-core that referenced this issue Feb 16, 2023

Enabled desktop screenhot feature by default

7cf07f9

fix brave/brave-browser#28560

simonhong closed this as completed in brave/brave-core#17252 Feb 16, 2023

brave-builds added this to the 1.50.x - Nightly milestone Feb 16, 2023

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 27, 2023

LaurenWags added the QA/Test-All-Platforms label Mar 14, 2023

LaurenWags mentioned this issue Mar 17, 2023

nightly on mac 12.6.3 (monterey) has "over-sized" screen size when taking a screen shot #29056

Open

LaurenWags added the QA/Blocked label Mar 20, 2023

LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Mar 30, 2023

LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 31, 2023

LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 3, 2023

stephendonner added the QA Pass-Win64 label Apr 3, 2023

LaurenWags mentioned this issue Apr 4, 2023

Desktop Release Notes for 1.50.x - Release #29496

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable sharing_hub::kDesktopScreenshots feature #28560

Enable sharing_hub::kDesktopScreenshots feature #28560

simonhong commented Feb 16, 2023 •

edited by rebron

Loading

LaurenWags commented Mar 20, 2023

LaurenWags commented Mar 30, 2023

LaurenWags commented Mar 31, 2023 •

edited

Loading

LaurenWags commented Apr 3, 2023 •

edited

Loading

stephendonner commented Apr 3, 2023 •

edited

Loading

Enable sharing_hub::kDesktopScreenshots feature #28560

Enable sharing_hub::kDesktopScreenshots feature #28560

Comments

simonhong commented Feb 16, 2023 • edited by rebron Loading

Description

Test Plan

LaurenWags commented Mar 20, 2023

LaurenWags commented Mar 30, 2023

LaurenWags commented Mar 31, 2023 • edited Loading

LaurenWags commented Apr 3, 2023 • edited Loading

stephendonner commented Apr 3, 2023 • edited Loading

Verification PASSED using

simonhong commented Feb 16, 2023 •

edited by rebron

Loading

LaurenWags commented Mar 31, 2023 •

edited

Loading

LaurenWags commented Apr 3, 2023 •

edited

Loading

stephendonner commented Apr 3, 2023 •

edited

Loading

Verification `PASSED` using