Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled desktop screenshot feature by default #17252

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 16, 2023

fix brave/brave-browser#28560

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

BraveMainDelegateBrowserTest.EnabledFeatures

Please see the linked issue for manual test.

@simonhong simonhong requested a review from a team as a code owner February 16, 2023 05:19
@simonhong simonhong self-assigned this Feb 16, 2023
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Feb 16, 2023
@simonhong simonhong changed the title Enabled desktop screenhot feature by default Enabled desktop screenshot feature by default Feb 16, 2023
@simonhong simonhong force-pushed the enable_sharing-desktop-screenshots branch from 3a90ad2 to 7cf07f9 Compare February 16, 2023 12:30
@simonhong simonhong requested a review from goodov February 16, 2023 12:31
@simonhong simonhong enabled auto-merge February 16, 2023 13:14
@simonhong simonhong merged commit 77f348d into master Feb 16, 2023
@simonhong simonhong deleted the enable_sharing-desktop-screenshots branch February 16, 2023 15:39
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable sharing_hub::kDesktopScreenshots feature
2 participants