Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy clean link is shown for plain text #28973

Closed
spylogsster opened this issue Mar 9, 2023 · 4 comments · Fixed by brave/brave-core#17541
Closed

Copy clean link is shown for plain text #28973

spylogsster opened this issue Mar 9, 2023 · 4 comments · Fixed by brave/brave-core#17541

Comments

@spylogsster
Copy link

spylogsster commented Mar 9, 2023

Description

This bug was introduced here brave/brave-core#17494

image

Steps to Reproduce

  1. Select any plain text on pages
  2. Click by right mouse button to show the context menu for the selection
  3. "Copy clean link" item will be visible in the context menu

Actual result:

"Copy clean link" item will be visible in the context menu

Expected result:

"Copy clean link" is visible only for selected urls

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

The above requires 1.49.126 or higher for 1.49.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Mar 21, 2023

Verified with

Brave | 1.49.126 Chromium: 111.0.5563.64 (Official Build) (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

Using the STR/Cases outlined via #28973 (comment), ensured that the Copy clean link item is not being added into the context menu for plain text as per the following:

  • ensured that plain text doesn't include the Copy clean link item within the right click context menu
  • ensured that Copy clean link is available for links
  • ensured that Copy clean link is available for image links
  • ensured that all tests under https://fmarier.github.io/brave-testing/copy-clean-link.html are passing as expected
Example Example Example Example Example
1 2 3 4 5

@btlechowski btlechowski added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 21, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.49.126 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Using the STR/Cases outlined via #28973 (comment), ensured that the Copy clean link item is not being added into the context menu for plain text as per the following:

  • ensured that plain text doesn't include the Copy clean link item within the right click context menu
  • ensured that Copy clean link is available for links
  • ensured that Copy clean link is available for image links
  • ensured that all tests under https://fmarier.github.io/brave-testing/copy-clean-link.html are passing as expected

image
image
image

Logged #29210

@btlechowski
Copy link

Verification passed on

Brave 1.49.126 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 10 Version 22H2 (Build 19045.2728)

Using the STR/Cases outlined via #28973 (comment), ensured that the Copy clean link item is not being added into the context menu for plain text as per the following:

  • ensured that plain text doesn't include the Copy clean link item within the right click context menu
  • ensured that Copy clean link is available for links
  • ensured that Copy clean link is available for image links
  • ensured that all tests under https://fmarier.github.io/brave-testing/copy-clean-link.html are passing as expected

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants