Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show copy clean link for plain text (uplift #17541) #17608

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Do not show copy clean link for plain text (uplift #17541) #17608

merged 2 commits into from
Mar 20, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 15, 2023 •
edited by kjozwiak
Loading

Uplift of #17541
Resolves brave/brave-browser#28973

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team as a code owner March 15, 2023 08:19
@spylogsster spylogsster self-assigned this Mar 15, 2023
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Mar 15, 2023
@spylogsster spylogsster changed the title Do not show copy clean link for plain text (#17541) Do not show copy clean link for plain text (uplift #17541) Mar 15, 2023
@spylogsster spylogsster mentioned this pull request Mar 15, 2023
Closed
@spylogsster spylogsster force-pushed the pr17541_brave-28973__1.50.x branch from b9c9efc to 907018d Compare March 17, 2023 10:29
@spylogsster
Do not show copy clean link for plain text (#17541)
4c5f2f8 
* Do not show copy clean link for plain text

* Added tests for clean link item
@spylogsster spylogsster force-pushed the pr17541_brave-28973__1.50.x branch from 907018d to 4c5f2f8 Compare March 20, 2023 06:40
@kjozwiak kjozwiak added this to the 1.50.x - Beta milestone Mar 20, 2023
kjozwiak
kjozwiak approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified the PR on Nightly as per #17541 (comment).

@kjozwiak kjozwiak merged commit 8fcf1e1 into 1.50.x Mar 20, 2023
@kjozwiak kjozwiak deleted the pr17541_brave-28973__1.50.x branch March 20, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spylogsster @kjozwiak