Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar's Show on right option should located first #30810

Closed
simonhong opened this issue Jun 5, 2023 · 1 comment · Fixed by brave/brave-core#18748
Closed

Sidebar's Show on right option should located first #30810

simonhong opened this issue Jun 5, 2023 · 1 comment · Fixed by brave/brave-core#18748

Comments

@simonhong
Copy link
Member

As we made right-side as a default for sidebar position, Show on right should be located before Show on left.

Screenshot 2023-06-05 at 2 07 12 PM
@simonhong simonhong self-assigned this Jun 5, 2023
simonhong added a commit to brave/brave-core that referenced this issue Jun 5, 2023
fix brave/brave-browser#30810

As we made right-side as a default for sidebar position,
"Show on right" should be located first.
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 5, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 7, 2023

Verifictaion PASSED using

Brave | 1.54.90 Chromium: 115.0.5790.56 (Official Build) beta (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Windows 11 Version 22H2 (Build 22621.1928)

Case 1: Fresh Install

  1. Install 1.54.90
  2. launch Brave
  3. open brave://settings/appearance

Confirmed Show on right setting shows on top of Show on left setting and the sidebar is shown on the right

Case 2: Upgrade

  1. Install 1.52.129
  2. launch Brave
  3. open brave://settings/appearance
  4. verified Show on left setting position is on top of Show on right and is shown as default
  5. enabled Show Sidebar Always from Hamburger menu and the sidebar is shown on left
  6. rename the profile to Brav-Browser-Beta
  7. relaunch Brave with 1.54.90
  8. verified brave://settings/appearance

Confirmed Show on right setting position is reversed and shows on top of Show on left setting

Confirmed Show on right setting shown as default and Sidebar is shown on right

step 4-5 step 8a step 8b
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants