Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218

Closed
GeetaSarvadnya opened this issue Jun 22, 2023 · 6 comments · Fixed by brave/brave-core#19017
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 22, 2023

Description

Found while testing #30200
CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52

Steps to Reproduce

The URL bar height is NOT matching the VPN buttons height it's a bit taller than the VPN button height
image

Actual result:

image

Expected result:

The taller URL bar looks odd in my view, it's better to revisit the design

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.55.2 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
Revision f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS Windows 10 Version 22H2 (Build 19045.3086)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No in CR114 nightly, reproducible only in CR115

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

CC: @emerick @rebron @brave/qa-team @aguscruiz

@emerick emerick changed the title CR 115 - The URL bar is a little wider in 1.54 as compared to 1.52 CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 Jun 22, 2023
@emerick
Copy link
Contributor

emerick commented Jun 22, 2023

I modified the title/description to clarify that the toolbar looks taller (not wider), as I was a bit confused until I read further into the issue - hope that's OK!

It is most likely due to this upstream change in cr115 which enables an increase of the "steady state" height of the omnibox: https://source.chromium.org/chromium/chromium/src/+/af83a2a402eb7242b2abe81ad8983e2a3884bccf

While this UI change is currently behind a feature flag, that flag will probably be going away shortly.

@kjozwiak
Copy link
Member

The above requires 1.53.108 or higher for 1.53.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 3, 2023

Verification PASSED using

Brave | 1.53.108 Chromium: 115.0.5790.56 (Official Build) (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Windows 11 Version 22H2 (Build 22621.1848)
  • Install 1.53.108
  • launched Brave

Confirmed visually the address bar height is fixed in 1.53.108

image

1.55.2 1.53.108 1.52.129
image image image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.53.108 Chromium: 115.0.5790.56 (Official Build) (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Linux
  • Install 1.53.108
  • launched Brave

Confirmed visually the address bar height is fixed in 1.53.108

Screenshot from 2023-07-03 12-48-55

1.55.2 1.53.108 1.52.129
image Screenshot from 2023-07-03 12-49-33 Screenshot from 2023-07-03 12-52-40

@stephendonner
Copy link

stephendonner commented Jul 7, 2023

Verified PASSED using

Brave 1.53.110 Chromium: 115.0.5790.56 (Official Build) (x86_64)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS macOS Version 11.7.8 (Build 20G1351)

Compared URL-bar heights between 1.55.2 and 1.53.110, and confirmed correct height was restored

1.55.2 / 1.53.110:
Screen Shot 2023-07-07 at 3 48 04 PM
Screen Shot 2023-07-07 at 3 36 44 PM

@LaurenWags
Copy link
Member

Changed to release-notes/exclude after conferring with @emerick

cc @kjozwiak @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants