-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52 #31218
Comments
I modified the title/description to clarify that the toolbar looks taller (not wider), as I was a bit confused until I read further into the issue - hope that's OK! It is most likely due to this upstream change in cr115 which enables an increase of the "steady state" height of the omnibox: https://source.chromium.org/chromium/chromium/src/+/af83a2a402eb7242b2abe81ad8983e2a3884bccf While this UI change is currently behind a feature flag, that flag will probably be going away shortly. |
The above requires |
Verification
Confirmed visually the address bar height is fixed in
|
Verified
|
Brave | 1.53.110 Chromium: 115.0.5790.56 (Official Build) (x86_64) |
---|---|
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193} |
OS | macOS Version 11.7.8 (Build 20G1351) |
Description
Found while testing #30200
CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52
Steps to Reproduce
The URL bar height is NOT matching the VPN buttons height it's a bit taller than the VPN button height

Actual result:
Expected result:
The taller URL bar looks odd in my view, it's better to revisit the design
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
CC: @emerick @rebron @brave/qa-team @aguscruiz
The text was updated successfully, but these errors were encountered: