Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable omnibox::kOmniboxSteadyStateHeight feature #19017

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Disable omnibox::kOmniboxSteadyStateHeight feature #19017

merged 1 commit into from
Jun 27, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jun 23, 2023

Resolves brave/brave-browser#31218

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick requested a review from a team as a code owner June 23, 2023 12:53
@emerick emerick self-assigned this Jun 23, 2023
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jun 23, 2023
@emerick emerick force-pushed the cr115-followup-disable-omnibox-steady-state-height-feature branch 2 times, most recently from 7c5256a to ff4190a Compare June 24, 2023 12:38
@ghost ghost mentioned this pull request Jun 26, 2023
Closed
@emerick emerick force-pushed the cr115-followup-disable-omnibox-steady-state-height-feature branch 2 times, most recently from 40f5859 to 38dbb74 Compare June 27, 2023 00:13
@emerick
Disable omnibox::kOmniboxSteadyStateHeight feature
a3c3f17 
This feature was making the omnibox slightly taller than usual, but we want to
disable that.

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/af83a2a402eb7242b2abe81ad8983e2a3884bccf

commit af83a2a402eb7242b2abe81ad8983e2a3884bccf
Author: manukh <[email protected]>
Date:   Tue Jun 13 19:57:04 2023 +0000

    [m115][omnibox][cr23] Launch SS height.

    m115 merge.

    Stable looked good: http://shortn/_Wr6Vp2p6h4

    (cherry picked from commit 4eda6e27090c76658af35789c0311118b1cc9b36)

    Bug: 1416351, 1451795, 1451795, 1368852
@emerick emerick force-pushed the cr115-followup-disable-omnibox-steady-state-height-feature branch from 38dbb74 to a3c3f17 Compare June 27, 2023 00:15
@emerick emerick merged commit df81071 into master Jun 27, 2023
@emerick emerick deleted the cr115-followup-disable-omnibox-steady-state-height-feature branch June 27, 2023 13:59
@emerick emerick added this to the 1.55.x - Nightly milestone Jun 27, 2023
This was referenced Jun 27, 2023
Merged
Merged
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.55.82 Chromium: 115.0.5790.40 (Official Build) nightly (64-bit)
-- | --
Revision | 17b08ed10a9c0c62b454728c35f8eebe33cbbd33
OS | Windows 11 Version 22H2 (Build 22621.1848)

Using the STR/Cases outlined via brave/brave-browser#31218, ensured that the omnibox was restored to the previous size once omnibox::kOmniboxSteadyStateHeight was disabled as per the following:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

Assignees

@emerick emerick

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.

CR 115 - The URL bar is a little taller in 1.54 as compared to 1.52
3 participants
@emerick @kjozwiak @goodov