Disable omnibox::kOmniboxSteadyStateHeight feature (uplift to 1.54.x) #19067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was making the omnibox slightly taller than usual, but we want to disable that. Chromium change: https://source.chromium.org/chromium/chromium/src/+/af83a2a402eb7242b2abe81ad8983e2a3884bccf commit af83a2a402eb7242b2abe81ad8983e2a3884bccf Author: manukh <[email protected]> Date: Tue Jun 13 19:57:04 2023 +0000 [m115][omnibox][cr23] Launch SS height. m115 merge. Stable looked good: http://shortn/_Wr6Vp2p6h4 (cherry picked from commit 4eda6e27090c76658af35789c0311118b1cc9b36) Bug: 1416351, 1451795, 1451795, 1368852
github-actions
bot
added
CI/run-network-audit
kjozwiak
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Uplift into 1.54.x approved 👍 QA has verified the PR on Nightly as per #19017 (comment).
kjozwiak
deleted the
cr115-followup-disable-omnibox-steady-state-height-feature-1.54.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #19017
Resolves brave/brave-browser#31218
In addition, this cherry-picks fixes for the following issues involving flaky upstream tests:
Resolves https://github.com/brave/internal/issues/1045
Resolves https://github.com/brave/internal/issues/1052
Resolves brave/brave-browser#31279
Resolves brave/brave-browser#31280
Resolves brave/brave-browser#31281
Resolves brave/brave-browser#31282
Resolves brave/brave-browser#31283
Resolves brave/brave-browser#31284
Resolves brave/brave-browser#31285
Uplift of #19014
Uplift of #19037
Uplift of #19042