Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu does not fully come up when long tapping on news article in landscape #31935

Closed
Uni-verse opened this issue Jul 27, 2023 · 2 comments · Fixed by brave/brave-core#19655
Assignees
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@Uni-verse
Copy link
Contributor

Description

When long pressing on articles in news feed in landscape, context menu does not fully come up

Steps to reproduce

  1. Install 1.56.x (app store)
  2. Rotate device to landscape
  3. Enable brave news
  4. Long tap on article
  5. Observe context menu

Actual result

Screenshot 2023-07-27 at 5 35 57 PM

Expected result

Screenshot 2023-07-27 at 5 35 42 PM

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM x64
  • Device type (Phone, Tablet, Phablet): Phone, Tablet, Samsung Galaxy S7, Samsung GS 21
  • Android version: 13

Brave version

Any production

@hffvld
Copy link
Contributor

hffvld commented Aug 2, 2023

I can see the same behavior for another screen on Galaxy Tab S8 in Landscape Mode.

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.56.18
Chromium: 115.0.5790.138 (Official Build) (64-bit) 
Revision: 0567db0e7dcdfee5c109c167119ac2a92b9b3e1a-refs/branch-heads/5790_85@{#9}

Screen_15-59-04

@hffvld
Copy link
Contributor

hffvld commented Sep 22, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.59.93
Chromium: 117.0.5938.88 (Official Build) beta (64-bit) 
Revision: 77474ed80832bd2c90be4ebf993b6c2a43f662b0

Brave News

STEPS:

  1. Launch Brave
  2. Enable Brave News from NTP or Settings > Brave News
  3. Rotate the device to Landscape mode
  4. Tap and hold on any news article > Verify

ACTUAL RESULTS:

  • Verified that the bottom sheet menu is fully opened in Landscape and Portrait modes
  • Verified that the bottom sheet menu is still fully opened when rotating the device

1 2
1 2
timestamp_19-30-43_19-31-32.mp4
Default browser

STEPS:

  1. Launch Brave and don't set it as the default browser
  2. Rotate the device to Landscape mode
  3. Three-dot menu > Set as Default Browser > Verify

ACTUAL RESULTS:

  • Verified that the bottom sheet menu is fully opened in Landscape and Portrait modes
  • Verified that the bottom sheet menu is still fully opened when rotating the device

1 2
1 2
timestamp_19-30-43_19-31-32.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants