Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 116.0.5845.51 to Chromium 116.0.5845.82 (1.57.x). #19640

Merged
merged 10 commits into from
Aug 10, 2023
Merged

Upgrade from Chromium 116.0.5845.51 to Chromium 116.0.5845.82 (1.57.x). #19640

merged 10 commits into from
Aug 10, 2023

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 10, 2023 •
edited
Loading

Resolves brave/brave-browser#32168
Resolves brave/brave-browser#31948

Uplift from #19471

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Aug 10, 2023
@mkarolin mkarolin requested a review from a team as a code owner August 10, 2023 00:30
@mkarolin mkarolin self-assigned this Aug 10, 2023
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) and removed CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Aug 10, 2023
@mkarolin mkarolin force-pushed the 116.0.5845.82_1.57.x branch from 9e31f05 to 65085cd Compare August 10, 2023 01:13
@cdesouza-chromium @mkarolin
Content Settings histogram values moved
4f19ea7 
Histogram values for Content Settings components include brave values.
These values are listed as part of a static flat map, and they have
recently been moved from a public header to a translation unit doing the
work with the representative value.

In this change we move the override and its implementation to the new
file.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/989b41b93018074f4647ab2352b7f051f1efd56a

commit 989b41b93018074f4647ab2352b7f051f1efd56a
Author: Florian Jacky <[email protected]>
Date:   Mon Jul 31 16:33:42 2023 +0000

    Enforce metadata expiry actively

    Previously, metadata expiration was only checked on access (i.e. on content setting retrieval). This means that a site that continually used a stream returned from a camera/microphone request, would not have this access revoked. Thus the stream would not be terminated on expiry. For cam/mic this halts active streams, for geolocation this will halt active streams once crbug.com/1462313 is fixed. Additionally this CL reduces the expiry of one time permissions from 24 hours to 16 hours, to prevent interruptive behaviour when clients would still use the capabilities the next day without triggering any of the other one time grant expiration mechanisms.

    Bug: 1457179, 1459994
@cdesouza-chromium @mkarolin
WebUIBubbleDialogView contructor with Arrow argument
626b559 
`WebUIBubbleDialogView` has had an extra argument `arrow` added to its
constructors. This means all instantiations of it in brave have to be
corrected to properly reflect that.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/ac6c2c4c7618aa22c64c515ef2f4533dc54ed5cd

commit ac6c2c4c7618aa22c64c515ef2f4533dc54ed5cd
Author: Yuheng Huang <[email protected]>
Date:   Mon Jun 26 17:42:46 2023 +0000

    Tab Search: Anchor bubble on top left when button is on the left side

    Add an option to anchor WebUI bubble on the left. This is necessary
    for Chrome UI refresh 2023 since the tab search button has moved to
    the left side of the tab strip.

    Change-Id: Icf3b6b2b3f63f17503d91129c0bb9498510a4c6e
    Bug: 1456312
@mkarolin mkarolin force-pushed the 116.0.5845.82_1.57.x branch from 65085cd to 626b559 Compare August 10, 2023 02:00
mkarolin and others added 3 commits August 9, 2023 23:22
@mkarolin
kVisualSearchSuggestions flag moved to a different build target.
8718bab 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/a3668b9a7ef9f0

commit a3668b9a7ef9f04c1f33286857689e54720549bb
Author: Pierre St Juste <[email protected]>
Date:   Fri Aug 4 19:12:35 2023 +0000

    [M116] Adding UKM logging for VQS in CSC.

    More context in the metrics doc http://shortn/_BlMxQQIsnL.

    (cherry picked from commit a3a495425fb51ccd9f1a93aff202ab4a4ef61e93)

    Bug: 1449021, b/285625378
@mkarolin
Disables failing upstream unit test.
5259a14
@goodov @mkarolin
Merge pull request #19471 from brave/issues/31948
aa6ea7f 
Disable tests that fail on SYSTEM account.
@kjozwiak kjozwiak added this to the 1.57.x - Release milestone Aug 10, 2023
kjozwiak
kjozwiak approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.57.x approved 👍

@kjozwiak kjozwiak merged commit 76bebd7 into 1.57.x Aug 10, 2023
@kjozwiak kjozwiak deleted the 116.0.5845.82_1.57.x branch August 10, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@mkarolin @kjozwiak @brave-builds @cdesouza-chromium @goodov